mirror of
https://github.com/servo/servo.git
synced 2025-10-17 16:59:27 +01:00
f3bacf84f4
Add rejection of out-of-range values for single-timing-functions <!-- Please describe your changes on the following line: --> This PR fixes #15344, checking for the `cubic-bezier p1x/p2x` and `steps` first value after parsing. There are unit tests that check for parsing of invalid values - I was not sure if there was a more suitable place, so I created a file (name subject to change). Q: I found this [test suite](https://github.com/servo/servo/blob/master/tests/unit/style/properties/serialization.rs#L592), and noticed that the `p2x` value is out of range, but the test does not fail - is this because there is no check when calling the function itself? Thanks! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15344 <!-- Either: --> - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15539) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| helpers | ||
| longhand | ||
| shorthand | ||
| build.py | ||
| data.py | ||
| declaration_block.rs | ||
| gecko.mako.rs | ||
| helpers.mako.rs | ||
| Mako-0.9.1.zip | ||
| properties.html.mako | ||
| properties.mako.rs | ||
