mirror of
https://github.com/servo/servo.git
synced 2025-07-23 07:13:52 +01:00
8d086b9fe5
On execution media element load algorithm https://html.spec.whatwg.org/multipage/media.html#media-element-load-algorithm we can observe race condition between parallel running fetch requests: R1: (media element) initial request (see "resource_fetch_algorithm" function) R2: (gstreamer) duration "seek-data" request (see PlayerEvent::SeekData) R3: (gstreamer) continue on last interrupted time "seek-data" request At time there are only one current fetch context for media element but because resource fetch and cancellation are async operations need to identify (by request id) and skip processing outdated fetch request (fetch listener callbacks). Async load in background sequence (stream content length = 2757913): ``` R1 (seek-offset=0): [------------------------------X] R2 (seek-offset=2757866): [---------Y] AS-****-+++-AE R3 (seek-offset=98304): [----------------Z] BS-****-+++BE R1 (seek-offset=0): [------X] R2 (seek-offset=2757866): [--------Y] (discarded data) AS-****---------+++-AE - A*/B* performed seeks (*** seek lock, +++ flush buffer queue + reset EOS) (on Gstreamer streaming thread) - X/Y/Z "end-of-stream" events from fetch requests (on Servo script thread) ``` All incoming input data from different requests are mixed and pushed to active media player, plus abnormal behaviour due to intermixed X/Y/Z "end-of-stream" events. To handle it properly we will unblock seek lock on "seek-data" event (on script thread) as soon as possible (GStreamer will be able to flush buffer queue and reset EOS state) and introduce buffered data source to delay pushing input data/EOS event until media player will be actually ready. Testing: Improvements to the following tests: - /html/canvas/element/manual/imagebitmap/createImageBitmap-origin.sub.html - /html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html Fixes: https://github.com/servo/servo/issues/31931 Fixes: https://github.com/servo/servo/issues/36989 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com> |
||
|---|---|---|
| .. | ||
| docs | ||
| dom | ||
| layout_dom | ||
| resources | ||
| svgpath | ||
| xpath | ||
| animation_timeline.rs | ||
| animations.rs | ||
| body.rs | ||
| build.rs | ||
| canvas_context.rs | ||
| canvas_state.rs | ||
| Cargo.toml | ||
| clipboard_provider.rs | ||
| conversions.rs | ||
| devtools.rs | ||
| document_collection.rs | ||
| document_loader.rs | ||
| drag_data_store.rs | ||
| fetch.rs | ||
| iframe_collection.rs | ||
| image_animation.rs | ||
| init.rs | ||
| layout_image.rs | ||
| lib.rs | ||
| links.rs | ||
| messaging.rs | ||
| microtask.rs | ||
| mime.rs | ||
| navigation.rs | ||
| network_listener.rs | ||
| realms.rs | ||
| routed_promise.rs | ||
| script_module.rs | ||
| script_runtime.rs | ||
| script_thread.rs | ||
| security_manager.rs | ||
| serviceworker_manager.rs | ||
| stylesheet_loader.rs | ||
| stylesheet_set.rs | ||
| task.rs | ||
| task_manager.rs | ||
| task_queue.rs | ||
| task_source.rs | ||
| test.rs | ||
| textinput.rs | ||
| timers.rs | ||
| unminify.rs | ||
| webdriver_handlers.rs | ||
| window_named_properties.rs | ||