mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
93615e14e5
Ensure reflow damage is calculated when hypothetical box changes. The layout traversal code has special handling for deciding whether to traverse text nodes or not. Specifically, unless the parent of a text node is restyled in a way that requires reconstructing the text fragment, we skip processing the text nodes as a performance optimization. The optimization causes a problem in hypothetical-box-dynamic.html, which tests that the rendering doesn't change when an absolutely-positioned span has an explicit block display removed (because absolutely-positioned elements should have hypothetical block boxes, regardless). However, the code to decide what restyling damage occurs when the block display is removed did not consider the hypothetical display, only the internal display value that treats absolute positioning as block display. By explicitly comparing the hypothetical display as well as the internal display, we ensure the element is restyled appropriately and the layout matches after the change. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes |
||
|---|---|---|
| .. | ||
| allocator | ||
| atoms | ||
| background_hang_monitor | ||
| bluetooth | ||
| bluetooth_traits | ||
| canvas | ||
| canvas_traits | ||
| compositing | ||
| config | ||
| config_plugins | ||
| constellation | ||
| deny_public_fields | ||
| derive_common | ||
| devtools | ||
| devtools_traits | ||
| dom_struct | ||
| domobject_derive | ||
| embedder_traits | ||
| fallible | ||
| geometry | ||
| gfx | ||
| gfx_traits | ||
| hashglobe | ||
| jstraceable_derive | ||
| layout | ||
| layout_2020 | ||
| layout_thread | ||
| layout_thread_2020 | ||
| layout_traits | ||
| malloc_size_of | ||
| media | ||
| metrics | ||
| msg | ||
| net | ||
| net_traits | ||
| pixels | ||
| profile | ||
| profile_traits | ||
| rand | ||
| range | ||
| remutex | ||
| script | ||
| script_layout_interface | ||
| script_plugins | ||
| script_traits | ||
| selectors | ||
| servo | ||
| servo_arc | ||
| size_of_test | ||
| std_test_override | ||
| style | ||
| style_derive | ||
| style_traits | ||
| to_shmem | ||
| to_shmem_derive | ||
| url | ||
| webdriver_server | ||
| webgpu | ||
| webrender_surfman | ||
| webrender_traits | ||