servo/python/servo/build_commands.py
Jonathan Schwender 0759dde11b
ohos: Fix mach build on windows hosts (#34113)
With the latest release (5.0) of the OpenHarmony SDK
libclang.dll is now available and we can support
building for OpenHarmony from windows hosts.

Other changes required for building OH on windows:
- We can't use the `<target_triple>-clang` wrappers, since
  those are bash scripts, which fails on windows when cc-rs
  tries to directly call them. However, we already pass all
  the required flags the wrapper script would set, so this
  is not an issue.
- We need to use posix paths, otherwise the sysroot parameter
  will not be applied correctly (by bindgen). It seems to only
  cause issues with bindgen in practice, possibly because
  bindgen interprets the path with
  [`shlex::split`](8a6d851318/bindgen/lib.rs (L312C27-L312C40))
  which presumably causes the issues with windows paths.
  To be consistent I decided to use posix paths for all paths.
- Fix checks for copying dlls. We need to check the target OS,
  not the host OS when determining what libraries to copy.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
2024-11-02 16:08:19 +00:00

357 lines
14 KiB
Python

# Copyright 2013 The Servo Project Developers. See the COPYRIGHT
# file at the top-level directory of this distribution.
#
# Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
# http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
# option. This file may not be copied, modified, or distributed
# except according to those terms.
import datetime
import os
import os.path as path
import pathlib
import shutil
import stat
import sys
from time import time
from typing import Optional
import notifypy
from mach.decorators import (
CommandArgument,
CommandProvider,
Command,
)
from mach.registrar import Registrar
import servo.platform
import servo.platform.macos
import servo.util
import servo.visual_studio
from servo.command_base import BuildType, CommandBase, call, check_call
from servo.gstreamer import windows_dlls, windows_plugins, package_gstreamer_dylibs
from servo.platform.build_target import BuildTarget
SUPPORTED_ASAN_TARGETS = ["aarch64-apple-darwin", "aarch64-unknown-linux-gnu",
"x86_64-apple-darwin", "x86_64-unknown-linux-gnu"]
@CommandProvider
class MachCommands(CommandBase):
@Command('build', description='Build Servo', category='build')
@CommandArgument('--jobs', '-j',
default=None,
help='Number of jobs to run in parallel')
@CommandArgument('--no-package',
action='store_true',
help='For Android, disable packaging into a .apk after building')
@CommandArgument('--verbose', '-v',
action='store_true',
help='Print verbose output')
@CommandArgument('--very-verbose', '-vv',
action='store_true',
help='Print very verbose output')
@CommandArgument('params', nargs='...',
help="Command-line arguments to be passed through to Cargo")
@CommandBase.common_command_arguments(build_configuration=True, build_type=True, package_configuration=True)
def build(self, build_type: BuildType, jobs=None, params=None, no_package=False,
verbose=False, very_verbose=False, with_asan=False, flavor=None, **kwargs):
opts = params or []
if build_type.is_release():
opts += ["--release"]
elif build_type.is_dev():
pass # there is no argument for debug
else:
opts += ["--profile", build_type.profile]
if jobs is not None:
opts += ["-j", jobs]
if verbose:
opts += ["-v"]
if very_verbose:
opts += ["-vv"]
env = self.build_env()
self.ensure_bootstrapped()
self.ensure_clobbered()
host = servo.platform.host_triple()
target_triple = self.target.triple()
if with_asan:
if target_triple not in SUPPORTED_ASAN_TARGETS:
print("AddressSanitizer is currently not supported on this platform\n",
"See https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html")
sys.exit(1)
# do not use crown (clashes with different rust version)
env["RUSTC"] = "rustc"
# Enable usage of unstable rust flags
env["RUSTC_BOOTSTRAP"] = "1"
# Enable asan
env["RUSTFLAGS"] = env.get("RUSTFLAGS", "") + " -Zsanitizer=address"
opts += ["-Zbuild-std"]
kwargs["target_override"] = target_triple
# TODO: Investigate sanitizers in C/C++ code:
# env.setdefault("CFLAGS", "")
# env.setdefault("CXXFLAGS", "")
# env["CFLAGS"] += " -fsanitize=address"
# env["CXXFLAGS"] += " -fsanitize=address"
# asan replaces system allocator with asan allocator
# we need to make sure that we do not replace it with jemalloc
self.features.append("servo_allocator/use-system-allocator")
build_start = time()
if host != target_triple and 'windows' in target_triple:
if os.environ.get('VisualStudioVersion') or os.environ.get('VCINSTALLDIR'):
print("Can't cross-compile for Windows inside of a Visual Studio shell.\n"
"Please run `python mach build [arguments]` to bypass automatic "
"Visual Studio shell, and make sure the VisualStudioVersion and "
"VCINSTALLDIR environment variables are not set.")
sys.exit(1)
# Gather Cargo build timings (https://doc.rust-lang.org/cargo/reference/timings.html).
opts = ["--timings"] + opts
if very_verbose:
print(["Calling", "cargo", "build"] + opts)
for key in env:
print((key, env[key]))
status = self.run_cargo_build_like_command(
"rustc", opts, env=env, verbose=verbose, **kwargs)
if status == 0:
built_binary = self.get_binary_path(build_type, asan=with_asan)
if not no_package and self.target.needs_packaging():
rv = Registrar.dispatch("package", context=self.context, build_type=build_type, flavor=flavor)
if rv:
return rv
if "windows" in target_triple:
if not copy_windows_dlls_to_build_directory(built_binary, self.target):
status = 1
elif "darwin" in target_triple:
servo_bin_dir = os.path.dirname(built_binary)
assert os.path.exists(servo_bin_dir)
if self.enable_media:
library_target_directory = path.join(path.dirname(built_binary), "lib/")
if not package_gstreamer_dylibs(built_binary, library_target_directory, self.target):
return 1
# On the Mac, set a lovely icon. This makes it easier to pick out the Servo binary in tools
# like Instruments.app.
try:
import Cocoa
icon_path = path.join(self.get_top_dir(), "resources", "servo_1024.png")
icon = Cocoa.NSImage.alloc().initWithContentsOfFile_(icon_path)
if icon is not None:
Cocoa.NSWorkspace.sharedWorkspace().setIcon_forFile_options_(icon,
built_binary,
0)
except ImportError:
pass
# Generate Desktop Notification if elapsed-time > some threshold value
elapsed = time() - build_start
elapsed_delta = datetime.timedelta(seconds=int(elapsed))
build_message = f"{'Succeeded' if status == 0 else 'Failed'} in {elapsed_delta}"
self.notify("Servo build", build_message)
print(build_message)
return status
@Command('clean',
description='Clean the target/ and python/_venv[version]/ directories',
category='build')
@CommandArgument('--manifest-path',
default=None,
help='Path to the manifest to the package to clean')
@CommandArgument('--verbose', '-v',
action='store_true',
help='Print verbose output')
@CommandArgument('params', nargs='...',
help="Command-line arguments to be passed through to Cargo")
def clean(self, manifest_path=None, params=[], verbose=False):
self.ensure_bootstrapped()
virtualenv_fname = '_venv%d.%d' % (sys.version_info[0], sys.version_info[1])
virtualenv_path = path.join(self.get_top_dir(), 'python', virtualenv_fname)
if path.exists(virtualenv_path):
print('Removing virtualenv directory: %s' % virtualenv_path)
shutil.rmtree(virtualenv_path)
opts = ["--manifest-path", manifest_path or path.join(self.context.topdir, "Cargo.toml")]
if verbose:
opts += ["-v"]
opts += params
return check_call(["cargo", "clean"] + opts, env=self.build_env(), verbose=verbose)
def notify(self, title: str, message: str):
"""Generate desktop notification when build is complete and the
elapsed build time was longer than 30 seconds.
If notify-command is set in the [tools] section of the configuration,
that is used instead."""
notify_command = self.config["tools"].get("notify-command")
# notifypy does not know how to send transient notifications, so we use a custom
# notifier on Linux. If transient notifications are not used, then notifications
# pile up in the notification center and must be cleared manually.
class LinuxNotifier(notifypy.BaseNotifier):
def __init__(self, **kwargs):
pass
def send_notification(self, **kwargs):
try:
import dbus
bus = dbus.SessionBus()
notify_obj = bus.get_object("org.freedesktop.Notifications", "/org/freedesktop/Notifications")
method = notify_obj.get_dbus_method("Notify", "org.freedesktop.Notifications")
method(
kwargs.get("application_name"),
0, # Don't replace previous notification.
kwargs.get("notification_icon", ""),
kwargs.get("notification_title"),
kwargs.get("notification_subtitle"),
[], # actions
{"transient": True}, # hints
-1 # timeout
)
except Exception as exception:
print(f"[Warning] Could not generate notification: {exception}",
file=sys.stderr)
return True
if notify_command:
if call([notify_command, title, message]) != 0:
print("[Warning] Could not generate notification: "
f"Could not run '{notify_command}'.", file=sys.stderr)
else:
try:
notifier = LinuxNotifier if sys.platform.startswith("linux") else None
notification = notifypy.Notify(use_custom_notifier=notifier)
notification.title = title
notification.message = message
notification.icon = path.join(self.get_top_dir(), "resources", "servo_64.png")
notification.send(block=False)
except notifypy.exceptions.UnsupportedPlatform as e:
print(f"[Warning] Could not generate notification: {e}", file=sys.stderr)
def copy_windows_dlls_to_build_directory(servo_binary: str, target: BuildTarget) -> bool:
servo_exe_dir = os.path.dirname(servo_binary)
assert os.path.exists(servo_exe_dir)
build_path = path.join(servo_exe_dir, "build")
assert os.path.exists(build_path)
# Copy in the built EGL and GLES libraries from where they were built to
# the final build dirctory
def find_and_copy_built_dll(dll_name):
try:
file_to_copy = next(pathlib.Path(build_path).rglob(dll_name))
shutil.copy(file_to_copy, servo_exe_dir)
except StopIteration:
print(f"WARNING: could not find {dll_name}")
print(" • Copying ANGLE DLLs to binary directory...")
find_and_copy_built_dll("libEGL.dll")
find_and_copy_built_dll("libGLESv2.dll")
print(" • Copying GStreamer DLLs to binary directory...")
if not package_gstreamer_dlls(servo_exe_dir, target):
return False
print(" • Copying MSVC DLLs to binary directory...")
if not package_msvc_dlls(servo_exe_dir, target):
return False
return True
def package_gstreamer_dlls(servo_exe_dir: str, target: BuildTarget):
gst_root = servo.platform.get().gstreamer_root(target)
if not gst_root:
print("Could not find GStreamer installation directory.")
return False
missing = []
for gst_lib in windows_dlls():
try:
shutil.copy(path.join(gst_root, "bin", gst_lib), servo_exe_dir)
except Exception:
missing += [str(gst_lib)]
for gst_lib in missing:
print("ERROR: could not find required GStreamer DLL: " + gst_lib)
if missing:
return False
# Only copy a subset of the available plugins.
gst_dlls = windows_plugins()
gst_plugin_path_root = os.environ.get("GSTREAMER_PACKAGE_PLUGIN_PATH") or gst_root
gst_plugin_path = path.join(gst_plugin_path_root, "lib", "gstreamer-1.0")
if not os.path.exists(gst_plugin_path):
print("ERROR: couldn't find gstreamer plugins at " + gst_plugin_path)
return False
missing = []
for gst_lib in gst_dlls:
try:
shutil.copy(path.join(gst_plugin_path, gst_lib), servo_exe_dir)
except Exception:
missing += [str(gst_lib)]
for gst_lib in missing:
print("ERROR: could not find required GStreamer DLL: " + gst_lib)
return not missing
def package_msvc_dlls(servo_exe_dir: str, target: BuildTarget):
def copy_file(dll_path: Optional[str]) -> bool:
if not dll_path or not os.path.exists(dll_path):
print(f"WARNING: Could not find DLL at {dll_path}", file=sys.stderr)
return False
servo_dir_dll = path.join(servo_exe_dir, os.path.basename(dll_path))
# Avoid permission denied error when overwriting DLLs.
if os.path.isfile(servo_dir_dll):
os.chmod(servo_dir_dll, stat.S_IWUSR)
print(f" • Copying {dll_path}")
shutil.copy(dll_path, servo_exe_dir)
return True
vs_platform = {
"x86_64": "x64",
"i686": "x86",
"aarch64": "arm64",
}[target.triple().split('-')[0]]
for msvc_redist_dir in servo.visual_studio.find_msvc_redist_dirs(vs_platform):
if copy_file(os.path.join(msvc_redist_dir, "msvcp140.dll")) and \
copy_file(os.path.join(msvc_redist_dir, "vcruntime140.dll")):
break
# Different SDKs install the file into different directory structures within the
# Windows SDK installation directory, so use a glob to search for a path like
# "**\x64\api-ms-win-crt-runtime-l1-1-0.dll".
windows_sdk_dir = servo.visual_studio.find_windows_sdk_installation_path()
dll_name = "api-ms-win-crt-runtime-l1-1-0.dll"
file_to_copy = next(pathlib.Path(windows_sdk_dir).rglob(os.path.join("**", vs_platform, dll_name)))
copy_file(file_to_copy)
return True