servo/components/script_bindings
Josh Matthews 9aa09d73b5
Fix crash when setting custom property on Location (#36494)
The JS engine uses types like `Handle<Maybe<PropertyDescriptor>>` in
various places and our automated bindings are not able to handle the
Maybe type. We have hand-written bindings that use outparams to indicate
a PropertyDescriptor value is actually the Nothing type, but that data
was getting lost when we passed the property descriptor to
SetPropertyIgnoringNamedGetter, which assumed that the property
descriptor was always valid.

Depends on https://github.com/servo/mozjs/pull/579.

Testing: Manual testing on testcase from
https://github.com/servo/servo/issues/34709, and new crashtest added.
Fixes: #34709

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
2025-04-16 06:52:48 +00:00
..
codegen async clipboard: implement writeText (#36498) 2025-04-14 13:49:43 +00:00
webidls media element: support seekable attribute (#36541) 2025-04-16 05:52:19 +00:00
build.rs script: Move code generation and webidl files to new script_bindings crate. (#35157) 2025-01-24 20:47:43 +00:00
callback.rs Implement "Create a Trusted Type" algorithm (#36454) 2025-04-13 03:55:23 +00:00
Cargo.toml Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
constant.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
constructor.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
conversions.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
error.rs Support optional message for dataclone error (#36308) 2025-04-13 18:10:04 +00:00
finalize.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
guard.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
import.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
inheritance.rs More miscellaneous script splitting changes (#36220) 2025-03-30 11:06:30 +00:00
interface.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
interfaces.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
iterable.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
lib.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
like.rs Move more bindings types to script_bindings (#35620) 2025-02-23 14:25:46 +00:00
lock.rs Miscellaneous script splitting preparation changes (#36216) 2025-03-29 08:11:27 +00:00
mem.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
namespace.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
num.rs Miscellaneous script splitting preparation changes (#36216) 2025-03-29 08:11:27 +00:00
principals.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
proxyhandler.rs Fix crash when setting custom property on Location (#36494) 2025-04-16 06:52:48 +00:00
realms.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
record.rs Move CustomTraceable to script_bindings. (#35988) 2025-03-16 14:08:22 +00:00
reflector.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
root.rs More miscellaneous script splitting changes (#36220) 2025-03-30 11:06:30 +00:00
script_runtime.rs Move more bindings code to script_bindings (#35578) 2025-02-22 04:46:56 +00:00
settings_stack.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
str.rs script: Implement input preprocessing for URLPatterns (#36225) 2025-04-04 23:42:28 +00:00
trace.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00
utils.rs Transfer ReadableStream (#36181) 2025-04-15 07:39:26 +00:00
weakref.rs Move generated bindings to script_bindings (#36323) 2025-04-04 06:45:08 +00:00