mirror of
https://github.com/servo/servo.git
synced 2025-06-10 09:33:13 +00:00
2bcee38e52
A rendering opportunity is now unconditionally triggered by handling IPC messages in the `ScriptThread`, unless animations are running in which case it's driven by the compositor. We can now remove calls to `note_rendering_opportunity` and `rendering_opportunity`. There is one tricky case, which is when a promise completion during a microtask checkpoint dirties the page again. In this case we need to trigger a new rendering opportunity, unless animations are running. In a followup change, when not driven by the compositor, rendering opportunities will be driven by a timed task, meaning we can remove this workaround. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
61 lines
1.8 KiB
Rust
61 lines
1.8 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use std::fmt;
|
|
use std::result::Result;
|
|
|
|
use base::id::PipelineId;
|
|
|
|
use crate::script_runtime::{CommonScriptMsg, ScriptChan, ScriptThreadEventCategory};
|
|
use crate::task::{TaskCanceller, TaskOnce};
|
|
use crate::task_source::{TaskSource, TaskSourceName};
|
|
|
|
#[derive(JSTraceable)]
|
|
pub struct RenderingTaskSource(pub Box<dyn ScriptChan + Send>, #[no_trace] pub PipelineId);
|
|
|
|
impl Clone for RenderingTaskSource {
|
|
fn clone(&self) -> RenderingTaskSource {
|
|
RenderingTaskSource(self.0.clone(), self.1)
|
|
}
|
|
}
|
|
|
|
impl fmt::Debug for RenderingTaskSource {
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
write!(f, "RenderingTaskSource(...)")
|
|
}
|
|
}
|
|
|
|
impl TaskSource for RenderingTaskSource {
|
|
const NAME: TaskSourceName = TaskSourceName::Rendering;
|
|
|
|
fn queue_with_canceller<T>(&self, task: T, canceller: &TaskCanceller) -> Result<(), ()>
|
|
where
|
|
T: TaskOnce + 'static,
|
|
{
|
|
let msg_task = CommonScriptMsg::Task(
|
|
ScriptThreadEventCategory::ScriptEvent,
|
|
Box::new(canceller.wrap_task(task)),
|
|
Some(self.1),
|
|
RenderingTaskSource::NAME,
|
|
);
|
|
|
|
self.0.send(msg_task).map_err(|_| ())
|
|
}
|
|
}
|
|
|
|
impl RenderingTaskSource {
|
|
/// This queues a task that will not be cancelled when its associated
|
|
/// global scope gets destroyed.
|
|
pub fn queue_unconditionally<T>(&self, task: T) -> Result<(), ()>
|
|
where
|
|
T: TaskOnce + 'static,
|
|
{
|
|
self.0.send(CommonScriptMsg::Task(
|
|
ScriptThreadEventCategory::NetworkEvent,
|
|
Box::new(task),
|
|
Some(self.1),
|
|
RenderingTaskSource::NAME,
|
|
))
|
|
}
|
|
}
|