mirror of
https://github.com/servo/servo.git
synced 2025-07-23 07:13:52 +01:00
08ef158d4e
This change splits the style and layout data in DOM nodes that is populated by style and layout passes. This makes Servo's data design more like Gecko's. This allows: 1. Removing the various `StyleAndLayout` data structures used by layout. 2. Removing the `GetStyleAndLayoutData` and `GetStyleAndOpaqueLayoutData` traits. Accessing style and layout data are now just functions on the `LayoutNode` and `ThreadSafeLayoutNode` traits. 3. Styling now doesn't populate layout data. This is is postponed until layout itself. 4. Allows the DOM wrappers to no longer have to be generic over the layout data. This data was already stored using `std::any::Any` and the new code just makes layout responsible for downcasting. Cleaning up the generic type parameter in the DOM wrappers can happen in a followup change. The main benefit to all of this is that we should be able to remove unsafe creation of `ServoLayoutNode` in layout and `TrustedLayoutNodeAddress` entirely, because `ServoLayoutNode` will be able to be passed directly from script to layout. In addition, this removes one more abstraction layer from the layout DOM wrappers, making the code a lot more understandable. Note: This increases the measured size of DOM types, but the same data is stored. It's simply that before that data was stored behind a heap pointer.
39 lines
1.9 KiB
Rust
39 lines
1.9 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use script::test::size_of;
|
|
|
|
// Macro so that we can stringify type names
|
|
// I'd really prefer the tests themselves to be run at plugin time,
|
|
// however rustc::middle doesn't have access to the full type data
|
|
macro_rules! sizeof_checker (
|
|
($testname: ident, $t: ident, $known_size: expr) => (
|
|
#[test]
|
|
fn $testname() {
|
|
let new = size_of::$t();
|
|
let old = $known_size;
|
|
if new < old {
|
|
panic!("Your changes have decreased the stack size of commonly used DOM struct {} from {} to {}. \
|
|
Good work! Please update the size in tests/unit/script/size_of.rs.",
|
|
stringify!($t), old, new)
|
|
} else if new > old {
|
|
panic!("Your changes have increased the stack size of commonly used DOM struct {} from {} to {}. \
|
|
These structs are present in large quantities in the DOM, and increasing the size \
|
|
may dramatically affect our memory footprint. Please consider choosing a design which \
|
|
avoids this increase. If you feel that the increase is necessary, \
|
|
update to the new size in tests/unit/script/size_of.rs.",
|
|
stringify!($t), old, new)
|
|
}
|
|
});
|
|
);
|
|
|
|
// Update the sizes here
|
|
sizeof_checker!(size_event_target, EventTarget, 48);
|
|
sizeof_checker!(size_node, Node, 200);
|
|
sizeof_checker!(size_element, Element, 376);
|
|
sizeof_checker!(size_htmlelement, HTMLElement, 392);
|
|
sizeof_checker!(size_div, HTMLDivElement, 392);
|
|
sizeof_checker!(size_span, HTMLSpanElement, 392);
|
|
sizeof_checker!(size_text, Text, 232);
|
|
sizeof_checker!(size_characterdata, CharacterData, 232);
|