mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
3af774bd75
The style candidate cache had regressed a few times (see #12534), and my intuition is that being able to disable all style sharing with a single rule in the page is really unfortunate. This commit redesigns the style sharing cache in order to be a optimistic cache, but then reject candidates if they match different sibling-affecting selectors in the page, for example. So far the numbers have improved, but not so much as I'd wanted (~10%/20% of non-incremental restyling time in general). The current implementation is really dumb though (we recompute and re-match a lot of stuff), so we should be able to optimise it quite a bit. I have different ideas for improving it (that may or may not work), apart of the low-hanging fruit like don't re-matching candidates all the time but I have to measure the real impact. Also, I need to verify it against try.
40 lines
1.3 KiB
Rust
40 lines
1.3 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Implements sequential traversal over the DOM tree.
|
|
|
|
use dom::TNode;
|
|
use traversal::{RestyleResult, DomTraversalContext};
|
|
|
|
pub fn traverse_dom<N, C>(root: N,
|
|
shared: &C::SharedContext)
|
|
where N: TNode,
|
|
C: DomTraversalContext<N>
|
|
{
|
|
fn doit<'a, N, C>(context: &'a C, node: N)
|
|
where N: TNode,
|
|
C: DomTraversalContext<N>
|
|
{
|
|
debug_assert!(context.should_process(node));
|
|
if let RestyleResult::Continue = context.process_preorder(node) {
|
|
for kid in node.children() {
|
|
context.pre_process_child_hook(node, kid);
|
|
if context.should_process(kid) {
|
|
doit::<N, C>(context, kid);
|
|
}
|
|
}
|
|
}
|
|
|
|
if context.needs_postorder_traversal() {
|
|
context.process_postorder(node);
|
|
}
|
|
}
|
|
|
|
let context = C::new(shared, root.opaque());
|
|
if context.should_process(root) {
|
|
doit::<N, C>(&context, root);
|
|
}
|
|
// Clear the local LRU cache since we store stateful elements inside.
|
|
context.local_context().style_sharing_candidate_cache.borrow_mut().clear();
|
|
}
|