mirror of
https://github.com/servo/servo.git
synced 2025-06-28 19:13:41 +01:00
e65b1be07b
I realized that I fixed this issue incorrectly when the test failed before. Our design document specifies that restyle hints must be expanded by the parent before traversing children, so that we can properly apply LaterSiblings restyle hints. This includes parents that do not themselves need processing (StylingMode::Traverse). So we need to preprocess children even in the case where we don't restyle the parent. On the flip side, we do in fact know whether a child needs processing before enqueuing it, so we can skip the conservative visit I added before. MozReview-Commit-ID: AEiRzdsN0h5
64 lines
2.3 KiB
Rust
64 lines
2.3 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use atomic_refcell::AtomicRefCell;
|
|
use context::{LocalStyleContext, SharedStyleContext, StyleContext};
|
|
use data::ElementData;
|
|
use dom::{NodeInfo, OpaqueNode, StylingMode, TElement, TNode};
|
|
use gecko::context::StandaloneStyleContext;
|
|
use gecko::wrapper::{GeckoElement, GeckoNode};
|
|
use std::mem;
|
|
use traversal::{DomTraversalContext, recalc_style_at};
|
|
|
|
pub struct RecalcStyleOnly<'lc> {
|
|
context: StandaloneStyleContext<'lc>,
|
|
root: OpaqueNode,
|
|
}
|
|
|
|
impl<'lc, 'ln> DomTraversalContext<GeckoNode<'ln>> for RecalcStyleOnly<'lc> {
|
|
type SharedContext = SharedStyleContext;
|
|
#[allow(unsafe_code)]
|
|
fn new<'a>(shared: &'a Self::SharedContext, root: OpaqueNode) -> Self {
|
|
// See the comment in RecalcStyleAndConstructFlows::new for an explanation of why this is
|
|
// necessary.
|
|
let shared_lc: &'lc Self::SharedContext = unsafe { mem::transmute(shared) };
|
|
RecalcStyleOnly {
|
|
context: StandaloneStyleContext::new(shared_lc),
|
|
root: root,
|
|
}
|
|
}
|
|
|
|
fn process_preorder(&self, node: GeckoNode<'ln>) {
|
|
if node.is_element() && (!self.context.shared_context().skip_root || node.opaque() != self.root) {
|
|
let el = node.as_element().unwrap();
|
|
recalc_style_at::<_, _, Self>(&self.context, self.root, el);
|
|
}
|
|
}
|
|
|
|
fn process_postorder(&self, _: GeckoNode<'ln>) {
|
|
unreachable!();
|
|
}
|
|
|
|
/// We don't use the post-order traversal for anything.
|
|
fn needs_postorder_traversal(&self) -> bool { false }
|
|
|
|
fn should_traverse_child(child: GeckoNode<'ln>) -> bool {
|
|
match child.as_element() {
|
|
Some(el) => el.styling_mode() != StylingMode::Stop,
|
|
None => false, // Gecko restyle doesn't need to traverse text nodes.
|
|
}
|
|
}
|
|
|
|
unsafe fn ensure_element_data<'a>(element: &'a GeckoElement<'ln>) -> &'a AtomicRefCell<ElementData> {
|
|
element.ensure_data()
|
|
}
|
|
|
|
unsafe fn clear_element_data<'a>(element: &'a GeckoElement<'ln>) {
|
|
element.clear_data()
|
|
}
|
|
|
|
fn local_context(&self) -> &LocalStyleContext {
|
|
self.context.local_context()
|
|
}
|
|
}
|