mirror of
https://github.com/servo/servo.git
synced 2025-06-24 17:14:33 +01:00
bdcf606f48
Before this change, Servo used one code path that computed the position of flows with `position: static` or `position: relative` and another separate code path that computed the position of flows with `position: absolute` or `position: fixed`. The latter code attempted to duplicate the former code to determine the static position of hypothetical boxes, but this was both fragile and incorrect in the case of hypothetical boxes nested inside floats. In fact, it's impossible to determine the static position of an absolute flow relative to its containing block at inline-size assignment time, because that static position could depend on a float that cannot be placed until block-size assignment! This patch changes block layout to use the same code path for static positioning of regular flows and static positioning of absolute flows where applicable. This both simplifies the code and improves its efficiency, since it allows the `hypothetical_position` field and `static_block_offsets` data structure to be removed. Moreover, it improves correctness in the above case (which the new reftest checks). This allows the sidebar in Facebook Timeline to be positioned properly. r? @glennw <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5691) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| canvas | ||
| compositing | ||
| devtools | ||
| devtools_traits | ||
| gfx | ||
| layout | ||
| layout_traits | ||
| msg | ||
| net | ||
| net_traits | ||
| plugins | ||
| profile | ||
| script | ||
| script_traits | ||
| servo | ||
| style | ||
| util | ||
| webdriver_server | ||
