mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
27c8a899ea
This reduces the memory used by the preload list to just 1.9MB. The
total memory savings in HSTS from
pre-103cbed928
is now 62MB, or 96%. And in terms of total resident memory is a 7.5%
reduction. The DAFSA/DAWG used by Firefox is 1.1MB so there could be
additional gains available but this seems like the best option based on
maintained libraries available (I could not find a good maintained
library for DAFSAs in Rust).
The main trick is this: the FST map API is currently designed to map
byte sequences to u64 values. Because we only need to determine if a
preloaded domain has the `includeSubdomains` flag set, we encode that
into the lowest bit of the ids in the map. This way finding an entry in
the map directly provides us with the `includeSubdomains` flag and we
don't need to keep another mapping in memory or on disk.
Updated the `./mach update-hsts-preload` command to generate the new FST
map file. (Not sure if I need to update any dev-dependencies anywhere
for this change)
This change also replaces the use of "mozilla.org" with "example.com" in
the HSTS unit tests to make sure that entries in the preload list do not
influence the tests (since example.com should not ever end up on the
preload list)
Testing: Updated unit tests
Fixes: #25929
---------
Signed-off-by: Sebastian C <sebsebmc@gmail.com>
53 lines
1.9 KiB
TOML
53 lines
1.9 KiB
TOML
[configs]
|
|
skip-check-length = false
|
|
skip-check-licenses = false
|
|
check-alphabetical-order = true
|
|
|
|
[ignore]
|
|
# Files that are ignored for all tidy and lint checks.
|
|
files = [
|
|
"./components/net/tests/parsable_mime/text",
|
|
"./resources/hsts_preload.fstmap",
|
|
"./tests/wpt/meta/MANIFEST.json",
|
|
"./tests/wpt/mozilla/meta/MANIFEST.json",
|
|
# Long encoded string
|
|
"./tests/wpt/mozilla/tests/mozilla/resources/brotli.py",
|
|
"./tests/wpt/webgl/meta/MANIFEST.json",
|
|
# Upstream code from Khronos/WebGL uses tabs for indentation
|
|
"./tests/wpt/webgl/tests",
|
|
# Vendored from upstream
|
|
"./tests/wpt/webgpu/tests",
|
|
# Our import script is not currently respecting the lint.
|
|
"./tests/wpt/webgl/tools/import-conformance-tests.py",
|
|
# Ignore those files since the issues reported are on purpose
|
|
"./tests/html/bad-line-ends.html",
|
|
"./tests/wpt/mozilla/tests/css/fonts",
|
|
"./tests/wpt/mozilla/tests/css/pre_with_tab.html",
|
|
"./tests/wpt/mozilla/tests/mozilla/textarea_placeholder.html",
|
|
]
|
|
# Directories that are ignored for the non-WPT tidy check.
|
|
directories = [
|
|
# Test have expectations in them, causing tidy to fail.
|
|
"./support/crown/tests",
|
|
# Upstream
|
|
"./support/android/apk",
|
|
"./tests/wpt/harness",
|
|
"./tests/wpt/tests",
|
|
"./tests/wpt/mozilla/tests/mozilla/referrer-policy",
|
|
"./tests/wpt/mozilla/tests/webgl",
|
|
"./python/tidy/tests",
|
|
"./python/mach",
|
|
# Generated and upstream code combined with our own. Could use cleanup
|
|
"./target",
|
|
"./support/crown/target",
|
|
"./third_party",
|
|
# Cache files generated by wptrunner which fail the EOF newlines check.
|
|
"./tests/wpt/meta/.cache",
|
|
"./tests/wpt/mozilla/meta/.cache",
|
|
"./tests/wpt/webgl/meta/.cache",
|
|
]
|
|
|
|
# Directories that are checked for correct file extension
|
|
[check_ext]
|
|
# directory, list of expected file extensions
|
|
"./components/script_bindings/webidls" = [".webidl", "noidl"]
|