mirror of
https://github.com/servo/servo.git
synced 2025-07-09 16:33:40 +01:00
b08d4a7d39
Make offset parent queries less buggy. <!-- Please describe your changes on the following line: --> Offset parent queries, which are used in the getters for HTMLElement's `offsetParent`, `offsetTop`, `offsetLeft`, `offsetWidth`, and `offsetHeight`, are pretty busted. The most egregious bug is that, as reported in #12939, inline elements are treated as if they're not present in the document. This PR fixes that and all of the other bugs I could trace directly to the offset parent query code, but `offsetTop` and `offsetLeft` are still unreliable in certain circumstances for reasons I haven't looked into (#13708). Inline elements with no content are still treated as not present due to #13982, so #13944 isn't fixed with this PR, either. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12939 and fix #12595 <!-- Either: --> - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14839) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| animation.rs | ||
| block.rs | ||
| Cargo.toml | ||
| construct.rs | ||
| context.rs | ||
| data.rs | ||
| display_list_builder.rs | ||
| flex.rs | ||
| floats.rs | ||
| flow.rs | ||
| flow_list.rs | ||
| flow_ref.rs | ||
| fragment.rs | ||
| generated_content.rs | ||
| incremental.rs | ||
| inline.rs | ||
| layout_debug.rs | ||
| lib.rs | ||
| linked_list.rs | ||
| list_item.rs | ||
| model.rs | ||
| multicol.rs | ||
| opaque_node.rs | ||
| parallel.rs | ||
| persistent_list.rs | ||
| query.rs | ||
| sequential.rs | ||
| table.rs | ||
| table_caption.rs | ||
| table_cell.rs | ||
| table_colgroup.rs | ||
| table_row.rs | ||
| table_rowgroup.rs | ||
| table_wrapper.rs | ||
| text.rs | ||
| traversal.rs | ||
| webrender_helpers.rs | ||
| wrapper.rs | ||
