mirror of
https://github.com/servo/servo.git
synced 2025-07-28 17:50:37 +01:00
c519739b7b
Add unit tests for cookies handling Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9965 Either: - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ Add unit tests for the `net` component about cookies. The tests are generated with a new `mach update-net-cookies` command from this repo: https://github.com/abarth/http-state. This PR also includes two trivial bug fixes about cookie handling. From all the tests included, the following ones are currently failing: - cookie_http_state::test_0003 - cookie_http_state::test_0006 - cookie_http_state::test_attribute0004 - cookie_http_state::test_attribute0005 - cookie_http_state::test_attribute0007 - cookie_http_state::test_attribute0008 - cookie_http_state::test_domain0017 - cookie_http_state::test_mozilla0001 - cookie_http_state::test_mozilla0002 - cookie_http_state::test_mozilla0003 - cookie_http_state::test_mozilla0005 - cookie_http_state::test_mozilla0007 - cookie_http_state::test_mozilla0009 - cookie_http_state::test_mozilla0010 - cookie_http_state::test_mozilla0013 `test_000[36]` and `test_mozilla*` are failing because there is currently no method to clean a `net::cookie_storage` from expired cookies. `test_attribute000[4578]` are failing because hyper does not parse the `Secure` attribute correctly. I will open an issue on the upstream project. `test_domain0017` fails because the TLD .org is not on the PUB_DOMAINS list. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11196) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| fetch | ||
| about_loader.rs | ||
| bluetooth_thread.rs | ||
| Cargo.toml | ||
| chrome_loader.rs | ||
| connector.rs | ||
| cookie.rs | ||
| cookie_storage.rs | ||
| data_loader.rs | ||
| file_loader.rs | ||
| filemanager_thread.rs | ||
| hsts.rs | ||
| http_loader.rs | ||
| image_cache_thread.rs | ||
| lib.rs | ||
| mime_classifier.rs | ||
| pub_domains.rs | ||
| resource_thread.rs | ||
| storage_thread.rs | ||
| websocket_loader.rs | ||
