mirror of
https://github.com/servo/servo.git
synced 2025-06-12 18:34:39 +00:00
c9480c8e07
Refactor ImageCache::find_image_or_metadata -> ImageCache::{get_image, track_image}
<!-- Please describe your changes on the following line: -->
Updated the `ImageCache` trait to replace `find_image_or_metadata` with two new functions `track_image` and `get_image`, as well as a new enum (`ImageCacheResult`).
As a result, I was able to refactor the functions that previously called `find_image_or_metadata` pretty cleanly. For a list of these functions, please see the commit information.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21289 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because tests already exist for these components. I ran `cargo test` in `net`, `net_traits`, `layout`, and `script` successfully.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23661)
<!-- Reviewable:end -->
|
||
|---|---|---|
| .. | ||
| display_list | ||
| tests | ||
| animation.rs | ||
| block.rs | ||
| Cargo.toml | ||
| construct.rs | ||
| context.rs | ||
| data.rs | ||
| flex.rs | ||
| floats.rs | ||
| flow.rs | ||
| flow_list.rs | ||
| flow_ref.rs | ||
| fragment.rs | ||
| generated_content.rs | ||
| incremental.rs | ||
| inline.rs | ||
| layout_debug.rs | ||
| lib.rs | ||
| linked_list.rs | ||
| list_item.rs | ||
| model.rs | ||
| multicol.rs | ||
| opaque_node.rs | ||
| parallel.rs | ||
| persistent_list.rs | ||
| query.rs | ||
| sequential.rs | ||
| table.rs | ||
| table_caption.rs | ||
| table_cell.rs | ||
| table_colgroup.rs | ||
| table_row.rs | ||
| table_rowgroup.rs | ||
| table_wrapper.rs | ||
| text.rs | ||
| traversal.rs | ||
| wrapper.rs | ||
