servo/components/shared/compositing
Martin Robinson c0970ea655
compositor: Wait for both Script and the Constellation when shutting down Pipelines (#37505)
Previously, the Constellation would immediately ask the Compositor to
shut down a pipeline, even before the ScriptThread finished shutting it
down. This meant that the Compositor might remove a Pipeline and then
re-add it if the ScriptThread sent a Pipeline-related message (such as a
new display list) in the meantime.

This change makes it so that the Compositor waits for both the
Constellation and the ScriptThread to finish shutting down a Pipeline
before removing its data. In addition, the Constellation no longer
synchronously waits on the Compositor when shutting down Pipelines. This
was important when the Compositor would talk to the ScriptThread
directly, but isn't necessary any longer.

Testing: This is very hard to test, because it depends on the creation
and destruction of many iframes and the particular timing of of all
the messaging between Servo bits. That said, this was tested manually
by observing the completion of Speedometer 2.1.
Fixes: #37458.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
2025-06-17 09:56:31 +00:00
..
tests compositor: Do not allow script to scroll beyond node boundaries (#37412) 2025-06-12 17:32:50 +00:00
Cargo.toml compositor: Do not allow script to scroll beyond node boundaries (#37412) 2025-06-12 17:32:50 +00:00
display_list.rs layout: Store scroll offsets in the ScrollTree (#37428) 2025-06-13 12:01:27 +00:00
lib.rs compositor: Wait for both Script and the Constellation when shutting down Pipelines (#37505) 2025-06-17 09:56:31 +00:00
rendering_context.rs compositing: Combine webrender_traits and compositing_traits (#36372) 2025-04-06 17:34:18 +00:00
viewport_description.rs Add support for parsing and applying viewport <meta> (#35901) 2025-06-06 15:13:51 +00:00