mirror of
https://github.com/servo/servo.git
synced 2025-07-03 13:33:39 +01:00
4307b6e67b
Ignore aborted responses in caching <!-- Please describe your changes on the following line: --> @jdm @KiChjang @Manishearth Follow up on https://github.com/servo/servo/pull/18676 and https://github.com/servo/servo/pull/19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19350) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| fetch | ||
| tests | ||
| blob_loader.rs | ||
| Cargo.toml | ||
| chrome_loader.rs | ||
| connector.rs | ||
| cookie.rs | ||
| cookie_storage.rs | ||
| data_loader.rs | ||
| filemanager_thread.rs | ||
| hosts.rs | ||
| hsts.rs | ||
| http_cache.rs | ||
| http_loader.rs | ||
| image_cache.rs | ||
| lib.rs | ||
| mime_classifier.rs | ||
| resource_thread.rs | ||
| storage_thread.rs | ||
| subresource_integrity.rs | ||
| websocket_loader.rs | ||
