mirror of
https://github.com/servo/servo.git
synced 2025-06-13 02:44:29 +00:00
75eb94afca
I moved away from the `Window` struct all the logic to handle task sources, into a new struct called `TaskManager`. In a happy world, I'd be able to just have there two functions, of the types: ```rust fn task_source<T: TaskSource>(&self, name: TaskSourceName) -> Box<T> fn task_source_with_canceller<T: TaskSource>(&self, name: TaskSourceName) -> (Box<T>, TaskSourceCanceller) ``` And not so much duplicated code. However, because TaskSource can't be a trait object (because it has generic type parameters), that's not possible. Instead, I decided to reduce duplicated logic through macros. For reasons[1], I have to pass both the name of the function with canceller and the name of the function without, as I'm not able to concatenate them in the macro itself. I could probably use `concat_idents` to create both types already defined and reduce the amount of arguments by one, but that macro is nightly only. At the same time, not being able to declare macros inside `impl` forces me to pass `self` as an argument. All this makes this solution more verbose than it would be ideally. It does reduce duplication, but it doesn't reduce the size of the file. [1](https://github.com/rust-lang/rust/issues/29599)
90 lines
3.1 KiB
Rust
90 lines
3.1 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use crate::dom::attr::Attr;
|
|
use crate::dom::bindings::codegen::Bindings::HTMLDetailsElementBinding;
|
|
use crate::dom::bindings::codegen::Bindings::HTMLDetailsElementBinding::HTMLDetailsElementMethods;
|
|
use crate::dom::bindings::inheritance::Castable;
|
|
use crate::dom::bindings::refcounted::Trusted;
|
|
use crate::dom::bindings::root::DomRoot;
|
|
use crate::dom::document::Document;
|
|
use crate::dom::element::AttributeMutation;
|
|
use crate::dom::eventtarget::EventTarget;
|
|
use crate::dom::htmlelement::HTMLElement;
|
|
use crate::dom::node::{window_from_node, Node};
|
|
use crate::dom::virtualmethods::VirtualMethods;
|
|
use crate::task_source::TaskSource;
|
|
use dom_struct::dom_struct;
|
|
use html5ever::{LocalName, Prefix};
|
|
use std::cell::Cell;
|
|
|
|
#[dom_struct]
|
|
pub struct HTMLDetailsElement {
|
|
htmlelement: HTMLElement,
|
|
toggle_counter: Cell<u32>,
|
|
}
|
|
|
|
impl HTMLDetailsElement {
|
|
fn new_inherited(
|
|
local_name: LocalName,
|
|
prefix: Option<Prefix>,
|
|
document: &Document,
|
|
) -> HTMLDetailsElement {
|
|
HTMLDetailsElement {
|
|
htmlelement: HTMLElement::new_inherited(local_name, prefix, document),
|
|
toggle_counter: Cell::new(0),
|
|
}
|
|
}
|
|
|
|
#[allow(unrooted_must_root)]
|
|
pub fn new(
|
|
local_name: LocalName,
|
|
prefix: Option<Prefix>,
|
|
document: &Document,
|
|
) -> DomRoot<HTMLDetailsElement> {
|
|
Node::reflect_node(
|
|
Box::new(HTMLDetailsElement::new_inherited(
|
|
local_name, prefix, document,
|
|
)),
|
|
document,
|
|
HTMLDetailsElementBinding::Wrap,
|
|
)
|
|
}
|
|
}
|
|
|
|
impl HTMLDetailsElementMethods for HTMLDetailsElement {
|
|
// https://html.spec.whatwg.org/multipage/#dom-details-open
|
|
make_bool_getter!(Open, "open");
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-details-open
|
|
make_bool_setter!(SetOpen, "open");
|
|
}
|
|
|
|
impl VirtualMethods for HTMLDetailsElement {
|
|
fn super_type(&self) -> Option<&dyn VirtualMethods> {
|
|
Some(self.upcast::<HTMLElement>() as &dyn VirtualMethods)
|
|
}
|
|
|
|
fn attribute_mutated(&self, attr: &Attr, mutation: AttributeMutation) {
|
|
self.super_type().unwrap().attribute_mutated(attr, mutation);
|
|
|
|
if attr.local_name() == &local_name!("open") {
|
|
let counter = self.toggle_counter.get() + 1;
|
|
self.toggle_counter.set(counter);
|
|
|
|
let window = window_from_node(self);
|
|
let this = Trusted::new(self);
|
|
// FIXME(nox): Why are errors silenced here?
|
|
let _ = window.task_manager().dom_manipulation_task_source().queue(
|
|
task!(details_notification_task_steps: move || {
|
|
let this = this.root();
|
|
if counter == this.toggle_counter.get() {
|
|
this.upcast::<EventTarget>().fire_event(atom!("toggle"));
|
|
}
|
|
}),
|
|
window.upcast(),
|
|
);
|
|
}
|
|
}
|
|
}
|