Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-03 05:23:38 +01:00
Code Issues Projects Releases Packages Wiki Activity
servo/components/style
History
bors-servo 2c73736f7d Auto merge of #18660 - upsuper:var-sub-inherit, r=emilio 
Don't use inherited custom properties for substitution

<!-- Please describe your changes on the following line: -->
Custom properties from parent node has been considered in early stage of cascading them (in [`custom_properties::cascade`](01adcf69d7/components/style/custom_properties.rs (L461-L469))), and there is nothing in the spec stating that substitution should take inherited values into consideration when the value is invalid in the current node. Actually, there is a web-platform test explicitly checks that inherited value is not taken when the value is computed to invalid.

This would fix [bug 1402217](https://bugzilla.mozilla.org/show_bug.cgi?id=1402217).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18660)
<!-- Reviewable:end -->
2017-09-28 09:06:48 -05:00
..
counter_style Measure PropertyDeclaration more thoroughly. 2017-09-14 13:18:03 +10:00
gecko style: update bindings. 2017-09-28 10:03:58 +02:00
gecko_bindings Stop allocating in fmt::Write for nsA[C]String 2017-09-27 13:51:02 -04:00
gecko_string_cache Update ns[C]String::from -> ns[C]Str::from where possible 2017-09-26 11:03:35 -04:00
invalidation Implement an nth-index cache. 2017-09-21 15:25:38 -07:00
properties Compute css variables with custom properties in keyframes for getKeyframes() 2017-09-27 18:27:57 +09:00
rule_tree style: Add a TLS-based style struct caching mechanism. 2017-09-14 17:13:39 +08:00
servo style: Cleanup some media-query-related code. 2017-09-26 14:49:25 +02:00
sharing Implement an nth-index cache. 2017-09-21 15:25:38 -07:00
stylesheets Update ns[C]String::from -> ns[C]Str::from where possible 2017-09-26 11:03:35 -04:00
values stylo: Handle quirks mode on font base sizes 2017-09-28 00:54:30 +03:00
animation.rs Filter out !important property in keyframes for servo. 2017-09-20 15:59:05 +09:00
applicable_declarations.rs Measure the UA cache. 2017-09-20 08:50:21 +10:00
attr.rs Replace all uses of the style::stylearc alias with servo_arc. 2017-07-19 09:29:05 +02:00
bezier.rs Don't use Point2D<f32> for cubic curves anymore 2017-07-19 10:19:41 +02:00
bloom.rs Un-inline some methods initializing thread_local! … 2017-09-12 11:42:04 +02:00
build.rs use cargo manifest path to find build.py script 2017-09-05 09:31:37 +02:00
build_gecko.rs Fix running cargo test -p stylo_test from repo root 2017-09-15 16:36:47 +02:00
Cargo.toml Hoist the LRU cache into its own crate to share it with selectors. 2017-09-20 23:22:20 -07:00
context.rs Implement an nth-index cache. 2017-09-21 15:25:38 -07:00
custom_properties.rs Don't use inherited custom properties for substitution 2017-09-28 19:46:53 +10:00
data.rs style: Massage the resolver code so it's cleaner and prevents the problem. 2017-09-18 04:57:50 +02:00
dom.rs style: Fix various issues with XBL rule matching. 2017-09-27 15:29:04 +02:00
driver.rs style: Lazily tweak the traversal root to account for sibling invalidations. 2017-09-26 13:09:03 +02:00
element_state.rs Overhaul MallocSizeOf and related things. 2017-09-12 12:37:51 +10:00
encoding_support.rs Use cssparser's new_with_line_number_offset 2017-08-28 12:49:30 -06:00
error_reporting.rs stylo: Error reporting for unknown media features 2017-09-08 12:48:50 +02:00
font_face.rs Implement size_hint for more iterators. 2017-09-13 20:29:27 -04:00
font_metrics.rs order derivable traits lists 2017-08-23 21:38:44 +02:00
hash.rs stylo: Add hash module for reexporting HashMap 2017-08-31 16:28:27 -07:00
lib.rs Hoist the LRU cache into its own crate to share it with selectors. 2017-09-20 23:22:20 -07:00
logical_geometry.rs order derivable traits lists 2017-08-23 21:38:44 +02:00
macros.rs Measure PropertyDeclaration more thoroughly. 2017-09-14 13:18:03 +10:00
matching.rs style: Early return and skip duplicate assertion in matching.rs 2017-09-25 10:59:34 +02:00
media_queries.rs stylo: Error reporting for unknown media features 2017-09-08 12:48:50 +02:00
parallel.rs Increase stack safety margin for stylo. 2017-09-07 11:44:45 -07:00
parser.rs Use cssparser's new_with_line_number_offset 2017-08-28 12:49:30 -06:00
README.md
rule_cache.rs stylo: Add keyword info to computed value of font-size 2017-09-23 10:51:21 -07:00
scoped_tls.rs Reduce the size of top_down_dom stackframes. 2017-06-08 13:02:36 -04:00
selector_map.rs Overhaul MallocSizeOf and related things. 2017-09-12 12:37:51 +10:00
selector_parser.rs Measure the UA cache. 2017-09-20 08:50:21 +10:00
shared_lock.rs style: Unify how servo and Gecko handle UA sheets. 2017-09-14 20:33:43 +02:00
str.rs Rework MediaType to be an atom-based struct instead of an enum. 2017-08-09 13:25:30 -07:00
style_adjuster.rs style: Handle correctly display changes from ruby to non-ruby in some edge cases. 2017-09-06 12:56:34 +02:00
style_resolver.rs Introduce an NthIndexCache type and pipe it from ThreadLocalStyleContext to MatchingContext. 2017-09-20 23:22:38 -07:00
stylesheet_set.rs style: Share user agent cascade data across documents. 2017-09-15 09:26:23 +02:00
stylist.rs style: Fix various issues with XBL rule matching. 2017-09-27 15:29:04 +02:00
thread_state.rs Explicitly register rayon threads, rather than assuming that as the default. 2017-09-19 13:04:35 -07:00
timer.rs order derivable traits lists 2017-08-23 21:38:44 +02:00
traversal.rs style: Lazily tweak the traversal root to account for sibling invalidations. 2017-09-26 13:09:03 +02:00
traversal_flags.rs style: Remove the for reconstruction traversals. 2017-09-01 13:13:50 +02:00

README.md

servo-style

Style system for Servo, using rust-cssparser for parsing.