mirror of
https://github.com/servo/servo.git
synced 2025-10-16 08:20:22 +01:00
318b23ed00
Don't log in the middle of mutating a reentrant lock <!-- Please describe your changes on the following line: --> Moved assertion that we are the lock owner to after the lock release. The problem is that Servo uses a reentrant lock for logging, so logging in the middle of mutating the lock is A Bad Idea. While I was at it, I tidied up the reentrant lock code. cc @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13463. - [X] These changes do not require tests because they fix an existing intermittent. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13472) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| fontconfig | ||
| performance | ||
| buildbot_steps.yml | ||
| chaos_monkey_test.py | ||
| check_dynamic_symbols.py | ||
| check_intermittents.sh | ||
| check_no_unwrap.sh | ||
| former_intermittents_css.txt | ||
| former_intermittents_wpt.txt | ||
| lockfile_changed.sh | ||
| manifest_changed.sh | ||
| servo-binary-formula.rb.in | ||
| update_brew.sh | ||
| upload_docs.sh | ||
| upload_nightly.sh | ||
| xorg.conf | ||
