mirror of
https://github.com/servo/servo.git
synced 2025-10-08 20:49:24 +01:00
ecf71d77cd
Add support for percentages in column-gap. <!-- Please describe your changes on the following line: --> # Changes in this PR * I've removed the `if product == "gecko"` line in order to make the column_gap type "NonNegativeLengthOrPercentageOrNormal" always. * Then I've changed this line ```rust Either::First(len) => len.into(), ``` to ```rust Either::First(len) => len.0.to_pixel_length(content_inline_size).into(), ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20498 (github issue number if applicable). <!-- Either: --> - [X] These changes do not require tests because there are tests already for this in wpt, in particular css/css-align/gaps/column-gap-parsing-001.html for the parsing bits, and css/css-multicol/multicol-gap-percentage-001.html for the layout bits. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20573) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| counter_style | ||
| gecko | ||
| gecko_bindings | ||
| gecko_string_cache | ||
| invalidation | ||
| properties | ||
| rule_tree | ||
| servo | ||
| sharing | ||
| stylesheets | ||
| values | ||
| animation.rs | ||
| applicable_declarations.rs | ||
| attr.rs | ||
| author_styles.rs | ||
| bezier.rs | ||
| bloom.rs | ||
| build.rs | ||
| build_gecko.rs | ||
| Cargo.toml | ||
| context.rs | ||
| custom_properties.rs | ||
| data.rs | ||
| dom.rs | ||
| dom_apis.rs | ||
| driver.rs | ||
| element_state.rs | ||
| encoding_support.rs | ||
| error_reporting.rs | ||
| font_face.rs | ||
| font_metrics.rs | ||
| hash.rs | ||
| lib.rs | ||
| logical_geometry.rs | ||
| macros.rs | ||
| matching.rs | ||
| media_queries.rs | ||
| parallel.rs | ||
| parser.rs | ||
| README.md | ||
| rule_cache.rs | ||
| scoped_tls.rs | ||
| selector_map.rs | ||
| selector_parser.rs | ||
| shared_lock.rs | ||
| str.rs | ||
| style_adjuster.rs | ||
| style_resolver.rs | ||
| stylesheet_set.rs | ||
| stylist.rs | ||
| thread_state.rs | ||
| timer.rs | ||
| traversal.rs | ||
| traversal_flags.rs | ||
