mirror of
https://github.com/servo/servo.git
synced 2025-06-08 08:33:26 +00:00
0ec2375cab
Recently, I found myself reading through the Python codegen scripts that live in 'components/script/dom/bindings/*' and noticed that there were many tidy violations: unnecessary semicolons, weird spacing, unused variables, lack of license headers, etc. Considering these files are now living in our tree and mostly maintained directly by contributors of Servo (as opposed to being from upstream), I feel these files should not be excluded from our normal tidy process. This commit removes the blacklist on these files and fixes all tidy violations. I added these subdirectories to the blacklist because they appear to be maintained upstream somewhere else: * "components/script/dom/bindings/codegen/parser/*", * "components/script/dom/bindings/codegen/ply/*", Also, I added a '# noqa' comment which tells us to ignore the flake8 errors for that line. I chose to ignore this (instead of fixing it) to make the work for this commit simpler for me.
26 lines
951 B
Python
26 lines
951 B
Python
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
import sys
|
|
import string
|
|
|
|
propList = eval(sys.stdin.read())
|
|
props = ""
|
|
for [prop, pref] in propList:
|
|
extendedAttrs = ["Throws", "TreatNullAs=EmptyString"]
|
|
if pref is not "":
|
|
extendedAttrs.append("Pref=%s" % pref)
|
|
if not prop.startswith("Moz"):
|
|
prop = prop[0].lower() + prop[1:]
|
|
# Unfortunately, even some of the getters here are fallible
|
|
# (e.g. on nsComputedDOMStyle).
|
|
props += " [%s] attribute DOMString %s;\n" % (", ".join(extendedAttrs),
|
|
prop)
|
|
|
|
idlFile = open(sys.argv[1], "r")
|
|
idlTemplate = idlFile.read()
|
|
idlFile.close()
|
|
|
|
print ("/* THIS IS AN AUTOGENERATED FILE. DO NOT EDIT */\n\n" +
|
|
string.Template(idlTemplate).substitute({"props": props}))
|