mirror of
https://github.com/servo/servo.git
synced 2025-06-08 08:33:26 +00:00
0ec2375cab
Recently, I found myself reading through the Python codegen scripts that live in 'components/script/dom/bindings/*' and noticed that there were many tidy violations: unnecessary semicolons, weird spacing, unused variables, lack of license headers, etc. Considering these files are now living in our tree and mostly maintained directly by contributors of Servo (as opposed to being from upstream), I feel these files should not be excluded from our normal tidy process. This commit removes the blacklist on these files and fixes all tidy violations. I added these subdirectories to the blacklist because they appear to be maintained upstream somewhere else: * "components/script/dom/bindings/codegen/parser/*", * "components/script/dom/bindings/codegen/ply/*", Also, I added a '# noqa' comment which tells us to ignore the flake8 errors for that line. I chose to ignore this (instead of fixing it) to make the work for this commit simpler for me.
82 lines
2.5 KiB
Python
82 lines
2.5 KiB
Python
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
# We do one global pass over all the WebIDL to generate our prototype enum
|
|
# and generate information for subsequent phases.
|
|
|
|
import sys
|
|
sys.path.append("./parser/")
|
|
sys.path.append("./ply/")
|
|
import os
|
|
import WebIDL
|
|
import cPickle
|
|
from Configuration import Configuration
|
|
from CodegenRust import GlobalGenRoots, replaceFileIfChanged
|
|
|
|
|
|
def generate_file(config, name, filename):
|
|
root = getattr(GlobalGenRoots, name)(config)
|
|
code = root.define()
|
|
|
|
if replaceFileIfChanged(filename, code):
|
|
print "Generating %s" % (filename)
|
|
else:
|
|
print "%s hasn't changed - not touching it" % (filename)
|
|
|
|
|
|
def main():
|
|
# Parse arguments.
|
|
from optparse import OptionParser
|
|
usageString = "usage: %prog [options] webidldir [files]"
|
|
o = OptionParser(usage=usageString)
|
|
o.add_option("--cachedir", dest='cachedir', default=None,
|
|
help="Directory in which to cache lex/parse tables.")
|
|
o.add_option("--verbose-errors", action='store_true', default=False,
|
|
help="When an error happens, display the Python traceback.")
|
|
(options, args) = o.parse_args()
|
|
|
|
if len(args) < 2:
|
|
o.error(usageString)
|
|
|
|
configFile = args[0]
|
|
baseDir = args[1]
|
|
fileList = args[2:]
|
|
|
|
# Parse the WebIDL.
|
|
parser = WebIDL.Parser(options.cachedir)
|
|
for filename in fileList:
|
|
fullPath = os.path.normpath(os.path.join(baseDir, filename))
|
|
f = open(fullPath, 'rb')
|
|
lines = f.readlines()
|
|
f.close()
|
|
parser.parse(''.join(lines), fullPath)
|
|
parserResults = parser.finish()
|
|
|
|
# Write the parser results out to a pickle.
|
|
resultsFile = open('ParserResults.pkl', 'wb')
|
|
cPickle.dump(parserResults, resultsFile, -1)
|
|
resultsFile.close()
|
|
|
|
# Load the configuration.
|
|
config = Configuration(configFile, parserResults)
|
|
|
|
# Generate the prototype list.
|
|
generate_file(config, 'PrototypeList', 'PrototypeList.rs')
|
|
|
|
# Generate the common code.
|
|
generate_file(config, 'RegisterBindings', 'RegisterBindings.rs')
|
|
|
|
# Generate the type list.
|
|
generate_file(config, 'InterfaceTypes', 'InterfaceTypes.rs')
|
|
|
|
# Generate the type list.
|
|
generate_file(config, 'InheritTypes', 'InheritTypes.rs')
|
|
|
|
# Generate the module declarations.
|
|
generate_file(config, 'Bindings', 'Bindings/mod.rs')
|
|
|
|
generate_file(config, 'UnionTypes', 'UnionTypes.rs')
|
|
|
|
if __name__ == '__main__':
|
|
main()
|