mirror of
https://github.com/servo/servo.git
synced 2025-10-09 04:59:23 +01:00
f29ddb4b5d
gfx: Fix bug with 1px width borders disappearing In to_nearest_azure_rect when rounding to pixel coordinates, maintain the invariant of rect non-overlap (if before rounding two rects don't overlap). The previous code rounded the rect top left corner to the nearest pixel with the size rounded to the nearest pixel multiple which can violate the non-overlap condition, e.g. 10px×9.60px at (0px,6.6px) & 10px×9.60px at (0px,16.2px) would round to 10px×10.0px at (0px,7.0px) & 10px×10.0px at (0px,16.0px), which overlap. Instead round each corner to the nearest pixel. For rects that dont need to satify the non-overlap condition and with width or height between 0.5px and 1px, rounding each rect corner to the nearest pixel can yield an empty rect e.g. 10px×0.6px at 0px,28.56px -> 10px×0px at 0px,29px. For this scenario a new function to_nearest_non_empty_azure_rect rounds the rect top left corner to the nearest pixel and the rect size to the nearest pixel multiple. It's possible for non-overlapping rects after this rounding to overlap. This should fix https://github.com/servo/servo/issues/7184 "rounding ...borders not to be visible", without breaking https://github.com/servo/servo/issues/7152 "Underlines less than 1px high sometimes invisible". r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7577) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| canvas | ||
| canvas_traits | ||
| compositing | ||
| devtools | ||
| devtools_traits | ||
| gfx | ||
| gfx_traits | ||
| layout | ||
| layout_traits | ||
| msg | ||
| net | ||
| net_traits | ||
| plugins | ||
| profile | ||
| profile_traits | ||
| script | ||
| script_traits | ||
| servo | ||
| style | ||
| style_traits | ||
| util | ||
| webdriver_server | ||
| webdriver_traits | ||
