mirror of
https://github.com/servo/servo.git
synced 2025-10-17 16:59:27 +01:00
f7ee1befc5
Support JS typed arrays as arguments and in WebIDL unions <!-- Please describe your changes on the following line: --> Supersedes #20205. This brings support to receiving typed arrays as function arguments (those are stack-rooted with CustomAutoRooter) and also being a member of a union (which is basically heap-rooted? similarly to other webidl unions). This is based on my other PR #20265 (which means it has to pull an external rust-mozjs branch and contains some also slightly unrelated changes here) since it shares `RootedTraceableBox::from_box` here and some other additional changes at rust-mozjs, but it can be easily separated if needed. I tried adding support to nullable typed arrays but couldn't work around an issue of codegen always sticking a "OrNull" at the end of my type (presumably because of [this](https://github.com/servo/servo/blob/master/components/script/dom/bindings/codegen/parser/WebIDL.py#L2241)?). How would I go about avoiding the suffix with nullable arguments? If we were to add also support for nullable typed arrays then I think we wouldn't be blocked anymore on this in WebGL 1.0. r? @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20267) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| allocator | ||
| atoms | ||
| bluetooth | ||
| bluetooth_traits | ||
| canvas | ||
| canvas_traits | ||
| compositing | ||
| config | ||
| constellation | ||
| debugger | ||
| deny_public_fields | ||
| devtools | ||
| devtools_traits | ||
| dom_struct | ||
| domobject_derive | ||
| fallible | ||
| geometry | ||
| gfx | ||
| gfx_traits | ||
| hashglobe | ||
| jstraceable_derive | ||
| layout | ||
| layout_thread | ||
| layout_traits | ||
| malloc_size_of | ||
| malloc_size_of_derive | ||
| metrics | ||
| msg | ||
| net | ||
| net_traits | ||
| nonzero | ||
| profile | ||
| profile_traits | ||
| rand | ||
| range | ||
| remutex | ||
| script | ||
| script_layout_interface | ||
| script_plugins | ||
| script_traits | ||
| selectors | ||
| servo | ||
| servo_arc | ||
| size_of_test | ||
| style | ||
| style_derive | ||
| style_traits | ||
| url | ||
| webdriver_server | ||
| webvr | ||
| webvr_traits | ||
