mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
f9e154af55
`CSSRule::Type()` returns an u16 for CSSOM. `InsertRule()` was incorrectly using this to create a `CssRuleTypes`. Instead of `CssRuleTypes::from_bits(rule_type)`, it should be something like `CssRuleTypes::from_bits(1 << rule_type)`. However, that would only work when `Type()` provides an actual value, which per https://drafts.csswg.org/cssom/#dom-cssrule-type only happens for old rule types. New rule types just return 0. Therefore, this patch changes the signature of `SpecificCSSRule::ty()` to return the actual `CssRuleType`, and then `CSSRule::Type()` can zero it out when necessary. The fix is only relevant for CSS Nesting, which is currently disabled on Servo, so no test is necessary. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because the fix is only relevant for CSS Nesting, which is currently disabled <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
88 lines
2.8 KiB
Rust
88 lines
2.8 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use dom_struct::dom_struct;
|
|
use servo_arc::Arc;
|
|
use style::shared_lock::{Locked, ToCssWithGuard};
|
|
use style::stylesheets::keyframes_rule::Keyframe;
|
|
use style::stylesheets::CssRuleType;
|
|
|
|
use crate::dom::bindings::codegen::Bindings::CSSKeyframeRuleBinding::CSSKeyframeRuleMethods;
|
|
use crate::dom::bindings::inheritance::Castable;
|
|
use crate::dom::bindings::reflector::{reflect_dom_object, DomObject};
|
|
use crate::dom::bindings::root::{Dom, DomRoot, MutNullableDom};
|
|
use crate::dom::bindings::str::DOMString;
|
|
use crate::dom::cssrule::{CSSRule, SpecificCSSRule};
|
|
use crate::dom::cssstyledeclaration::{CSSModificationAccess, CSSStyleDeclaration, CSSStyleOwner};
|
|
use crate::dom::cssstylesheet::CSSStyleSheet;
|
|
use crate::dom::window::Window;
|
|
|
|
#[dom_struct]
|
|
pub struct CSSKeyframeRule {
|
|
cssrule: CSSRule,
|
|
#[ignore_malloc_size_of = "Arc"]
|
|
#[no_trace]
|
|
keyframerule: Arc<Locked<Keyframe>>,
|
|
style_decl: MutNullableDom<CSSStyleDeclaration>,
|
|
}
|
|
|
|
impl CSSKeyframeRule {
|
|
fn new_inherited(
|
|
parent_stylesheet: &CSSStyleSheet,
|
|
keyframerule: Arc<Locked<Keyframe>>,
|
|
) -> CSSKeyframeRule {
|
|
CSSKeyframeRule {
|
|
cssrule: CSSRule::new_inherited(parent_stylesheet),
|
|
keyframerule,
|
|
style_decl: Default::default(),
|
|
}
|
|
}
|
|
|
|
#[allow(crown::unrooted_must_root)]
|
|
pub fn new(
|
|
window: &Window,
|
|
parent_stylesheet: &CSSStyleSheet,
|
|
keyframerule: Arc<Locked<Keyframe>>,
|
|
) -> DomRoot<CSSKeyframeRule> {
|
|
reflect_dom_object(
|
|
Box::new(CSSKeyframeRule::new_inherited(
|
|
parent_stylesheet,
|
|
keyframerule,
|
|
)),
|
|
window,
|
|
)
|
|
}
|
|
}
|
|
|
|
impl CSSKeyframeRuleMethods for CSSKeyframeRule {
|
|
// https://drafts.csswg.org/css-animations/#dom-csskeyframerule-style
|
|
fn Style(&self) -> DomRoot<CSSStyleDeclaration> {
|
|
self.style_decl.or_init(|| {
|
|
let guard = self.cssrule.shared_lock().read();
|
|
CSSStyleDeclaration::new(
|
|
self.global().as_window(),
|
|
CSSStyleOwner::CSSRule(
|
|
Dom::from_ref(self.upcast()),
|
|
self.keyframerule.read_with(&guard).block.clone(),
|
|
),
|
|
None,
|
|
CSSModificationAccess::ReadWrite,
|
|
)
|
|
})
|
|
}
|
|
}
|
|
|
|
impl SpecificCSSRule for CSSKeyframeRule {
|
|
fn ty(&self) -> CssRuleType {
|
|
CssRuleType::Keyframe
|
|
}
|
|
|
|
fn get_css(&self) -> DOMString {
|
|
let guard = self.cssrule.shared_lock().read();
|
|
self.keyframerule
|
|
.read_with(&guard)
|
|
.to_css_string(&guard)
|
|
.into()
|
|
}
|
|
}
|