mirror of
https://github.com/servo/servo.git
synced 2025-06-29 03:23:41 +01:00
Add VTTRegion and part of VTTCue DOM interfaces <!-- Please describe your changes on the following line: --> Hello! In this PR I implemented the VTTRegion DOM interface and part of VTTCue (#22312). Before continuing I thought it's maybe a good idea to first request a review or even merge what I did up to this point, as I might get stuck on the next part. I have a slight idea of what needs to be done (I assume it's hooking the GStreamer parser somewhere in `GetCueAsHTML()`), but a short outline or some more instructions would help a lot. I updated test expectations by first running: ``` ./mach test-wpt tests/wpt/web-platform-tests/webvtt/api --log-raw servo.log --pref dom.webvtt.enabled=true ``` then ``` ./mach update-wpt servo.log ``` Thanks! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> |
||
---|---|---|
.. | ||
ahem | ||
user-agent-js | ||
ahem.css | ||
android_params | ||
badcert.html | ||
badcert.jpg | ||
cert-google-only | ||
cert-wpt-only | ||
certs | ||
Credits.rtf.mako | ||
gatt_blocklist.txt | ||
hsts_preload.json | ||
iso-8859-8.css | ||
media-controls.css | ||
media-controls.js | ||
neterror.html | ||
not-found.html | ||
package-prefs.json | ||
prefs.json | ||
presentational-hints.css | ||
privatekey_for_testing.key | ||
public_domains.txt | ||
quirks-mode.css | ||
quotes.css | ||
rippy.png | ||
self_signed_certificate_for_testing.crt | ||
servo-64.png | ||
servo-100.png | ||
servo-500-icon.ico | ||
servo-500.png | ||
servo-1000.png | ||
servo-1024.png | ||
servo.css | ||
servo.icns | ||
Servo.ico | ||
servo.png | ||
servo.svg | ||
servo64.png | ||
tumbeast.png | ||
user-agent.css |