mirror of
https://github.com/servo/servo.git
synced 2025-10-04 10:39:16 +01:00
fa7107ac12
Simplify layout of absolutes with static insets Absolutes with static insets need to be laid out at their ancestor containing blocks, but their position is dependent on their parent's layout. The static layout position is passed up the tree during hoisting and ancestors each add their own offset to the position until it is relative to the containing block that contains the absolute. This is currently done with a closure and a fairly tricky "tree rank" numbering system that needs to be threaded through the entire layout. This change replaces that system. Every time a child is laid out we create a positioning context to hold any absolute children (this can be optimized away at a later time). At each of these moments, we call a method to aggregate offsets to the static insets of hoisted absolutes. This makes the logic easier to follow and will also allow implementing this behavior for inline-blocks, which was impossible with the old system. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it should not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> |
||
|---|---|---|
| .. | ||
| display_list | ||
| flexbox | ||
| flow | ||
| fragment_tree | ||
| tests | ||
| Cargo.toml | ||
| cell.rs | ||
| context.rs | ||
| dom.rs | ||
| dom_traversal.rs | ||
| formatting_contexts.rs | ||
| geom.rs | ||
| layout_debug.rs | ||
| lib.rs | ||
| lists.rs | ||
| positioned.rs | ||
| query.rs | ||
| replaced.rs | ||
| sizing.rs | ||
| style_ext.rs | ||
| traversal.rs | ||