Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-23 05:10:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

profile: Remove integration with Instruments.app "Points of Interest" (#39354)

Browse source 
This changes removes the integration with Instruments.app "Points of
Interest" track for a variety of reasons:

 - This functionality is made somewhat redundant by Servo's support for
   Perfetto traces.
 - This functionality depends on the `signpost` crate which hasn't seen
   activity for 9 years and only supports macOS.

Testing: This removes some functionality that is only observable via
Instruments.app, so testing it is difficult.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-09-18 04:37:00 +02:00 • committed by GitHub
parent 054b35e5b0
commit 020b82e1fe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 1 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/config/opts.rs
View file

@ -133,10 +133,6 @@ pub struct DebugOptions {
/// Log GC passes and their durations.
pub gc_profile: bool,
/// True to use OS native signposting facilities. This makes profiling events (script activity,
/// reflow, compositing, etc.) appear in Instruments.app on macOS.
pub signpost: bool,
}
impl DebugOptions {
@ -156,7 +152,6 @@ impl DebugOptions {
"gc-profile" => self.gc_profile = true,
"profile-script-events" => self.profile_script_events = true,
"relayout-event" => self.relayout_event = true,
"signpost" => self.signpost = true,
"" => {},
_ => return Err(String::from(option)),
};

1
components/shared/profile/Cargo.toml
View file

@ -24,6 +24,5 @@ malloc_size_of_derive = { workspace = true }
serde = { workspace = true }
servo_allocator = { path = "../../allocator" }
servo_config = { path = "../../config" }
signpost = { git = "https://github.com/pcwalton/signpost.git" }
time = { workspace = true }
tracing = { workspace = true, optional = true }

8
components/shared/profile/time.rs
View file

@ -7,7 +7,6 @@ use ipc_channel::ipc::IpcSender;
use log::warn;
use malloc_size_of_derive::MallocSizeOf;
use serde::{Deserialize, Serialize};
use servo_config::opts;
use time::Duration;
#[derive(Clone, Debug, Deserialize, Eq, Ord, PartialEq, PartialOrd, Serialize)]
@ -197,9 +196,6 @@ pub fn profile<T, F>(
where
F: FnOnce() -> T,
{
if opts::get().debug.signpost {
signpost::start(category as u32, &[0, 0, 0, (category as usize) >> 4]);
}
let start_time = CrossProcessInstant::now();
let val = {
#[cfg(feature = "tracing")]
@ -208,10 +204,6 @@ where
};
let end_time = CrossProcessInstant::now();
if opts::get().debug.signpost {
signpost::end(category as u32, &[0, 0, 0, (category as usize) >> 4]);
}
send_profile_data(category, meta, &profiler_chan, start_time, end_time);
val
}