Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix mistakes in webdriver element send keys (#37286)

Browse source 
Fix mistakes from https://github.com/servo/servo/pull/37224. We should
return in the middle of send keys if the element is either file input or
non typeable form control.

Fixes:
https://github.com/servo/servo/pull/37224#pullrequestreview-2903871157

Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
This commit is contained in:
Kenzie Raditya Tirtarahardja 2025-06-06 20:39:15 +08:00 • committed by GitHub
parent d246e80844
commit 097bd9d87f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/webdriver_server/lib.rs
View file

@ -1633,7 +1633,7 @@ impl Handler {
// TODO: distinguish the not found and not focusable cases
// File input and non-typeable form control should have
// been handled in `webdriver_handler.rs`.
if wait_for_script_response(receiver)?.map_err(|error| WebDriverError::new(error, ""))? {
if !wait_for_script_response(receiver)?.map_err(|error| WebDriverError::new(error, ""))? {
return Ok(WebDriverResponse::Void);
}

3
tests/wpt/meta/webdriver/tests/classic/element_send_keys/form_controls.py.ini vendored
View file

@ -4,3 +4,6 @@
[test_textarea_append]
expected: FAIL
[test_date]
expected: FAIL

3
tests/wpt/meta/webdriver/tests/classic/element_send_keys/send_keys.py.ini vendored
View file

@ -7,6 +7,3 @@
[test_no_such_element_from_other_window_handle[closed\]]
expected: FAIL
[test_surrogates]
expected: FAIL