mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
Auto merge of #25864 - mrobinson:rename-layout, r=jdm
Rename AbsolutelyPositionedBox::layout to AbsolutelyPositionedBox::to_hoisted This method doesn't actually do any layout, but converts this block to a HoistedAbsolutelyPositionedBox which is hoisted and then laid-out with its containing block later. This makes the code a little easier to read. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it does not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
commit
1fa0863f28
3 changed files with 3 additions and 3 deletions
|
@ -255,7 +255,7 @@ impl InlineFormattingContext {
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
ifc.positioning_context
|
ifc.positioning_context
|
||||||
.push(box_.layout(initial_start_corner, tree_rank));
|
.push(box_.to_hoisted(initial_start_corner, tree_rank));
|
||||||
},
|
},
|
||||||
InlineLevelBox::OutOfFlowFloatBox(_box_) => {
|
InlineLevelBox::OutOfFlowFloatBox(_box_) => {
|
||||||
// TODO
|
// TODO
|
||||||
|
|
|
@ -320,7 +320,7 @@ impl BlockLevelBox {
|
||||||
))
|
))
|
||||||
},
|
},
|
||||||
BlockLevelBox::OutOfFlowAbsolutelyPositionedBox(box_) => {
|
BlockLevelBox::OutOfFlowAbsolutelyPositionedBox(box_) => {
|
||||||
positioning_context.push(box_.layout(Vec2::zero(), tree_rank));
|
positioning_context.push(box_.to_hoisted(Vec2::zero(), tree_rank));
|
||||||
Fragment::Anonymous(AnonymousFragment::no_op(
|
Fragment::Anonymous(AnonymousFragment::no_op(
|
||||||
containing_block.style.writing_mode,
|
containing_block.style.writing_mode,
|
||||||
))
|
))
|
||||||
|
|
|
@ -86,7 +86,7 @@ impl AbsolutelyPositionedBox {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub(crate) fn layout(
|
pub(crate) fn to_hoisted(
|
||||||
&self,
|
&self,
|
||||||
initial_start_corner: Vec2<Length>,
|
initial_start_corner: Vec2<Length>,
|
||||||
tree_rank: usize,
|
tree_rank: usize,
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue