style: The 'all' property is not animatable.

Since it allows to animate display, which is not good.

This is a regression from:

  https://hg.mozilla.org/mozilla-central/rev/6884ba750aa3

Actually I wonder if the logic shouldn't be the other way around, i.e., a
shorthand is animatable if all the longhands are, not if just one.

In any case this rolls back to the previous behavior, should we do that, it
should be another bug.

Differential Revision: https://phabricator.services.mozilla.com/D14632
This commit is contained in:
Emilio Cobos Álvarez 2018-12-15 22:48:37 +00:00
parent 4799e83e3c
commit 31838b1e6f

View file

@ -388,12 +388,12 @@ class Shorthand(object):
and allowed_in_keyframe_block != "False" and allowed_in_keyframe_block != "False"
def get_animatable(self): def get_animatable(self):
animatable = False if self.ident == "all":
return False
for sub in self.sub_properties: for sub in self.sub_properties:
if sub.animatable: if sub.animatable:
animatable = True return True
break return False
return animatable
def get_transitionable(self): def get_transitionable(self):
transitionable = False transitionable = False