mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Fix timing of change events for <select>
elements (#37293)
Fixes two silly bugs in the implementation of `<select>` elements. * We did not fire `input` events * We fired `change` events *before* updating the selected value Both of these are only relevant when the embedder selects a value, so due to our lack of webdriver support we can't test them. With these changes it is possible to switch the language on https://toolbox.googleapps.com/apps/main/. --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
parent
097bd9d87f
commit
32cffbc985
3 changed files with 61 additions and 20 deletions
|
@ -1124,7 +1124,13 @@ impl TaskOnce for EventTask {
|
|||
let target = self.target.root();
|
||||
let bubbles = self.bubbles;
|
||||
let cancelable = self.cancelable;
|
||||
target.fire_event_with_params(self.name, bubbles, cancelable, CanGc::note());
|
||||
target.fire_event_with_params(
|
||||
self.name,
|
||||
bubbles,
|
||||
cancelable,
|
||||
EventComposed::NotComposed,
|
||||
CanGc::note(),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue