Fix timing of change events for <select> elements (#37293)

Fixes two silly bugs in the implementation of `<select>` elements.
* We did not fire `input` events
* We fired `change` events *before* updating the selected value

Both of these are only relevant when the embedder selects a value, so
due to our lack of webdriver support we can't test them.

With these changes it is possible to switch the language on
https://toolbox.googleapps.com/apps/main/.

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-06-06 16:01:12 +02:00 committed by GitHub
parent 097bd9d87f
commit 32cffbc985
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 61 additions and 20 deletions

View file

@ -1124,7 +1124,13 @@ impl TaskOnce for EventTask {
let target = self.target.root();
let bubbles = self.bubbles;
let cancelable = self.cancelable;
target.fire_event_with_params(self.name, bubbles, cancelable, CanGc::note());
target.fire_event_with_params(
self.name,
bubbles,
cancelable,
EventComposed::NotComposed,
CanGc::note(),
);
}
}