Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix timing of change events for <select> elements (#37293)

Browse source 
Fixes two silly bugs in the implementation of `<select>` elements.
* We did not fire `input` events
* We fired `change` events *before* updating the selected value

Both of these are only relevant when the embedder selects a value, so
due to our lack of webdriver support we can't test them.

With these changes it is possible to switch the language on
https://toolbox.googleapps.com/apps/main/.

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-06-06 16:01:12 +02:00 • committed by GitHub
parent 097bd9d87f
commit 32cffbc985
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 61 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/eventtarget.rs
View file

@ -59,7 +59,7 @@ use crate::dom::bindings::trace::HashMapTracedValues;
use crate::dom::document::Document;
use crate::dom::element::Element;
use crate::dom::errorevent::ErrorEvent;
use crate::dom::event::{Event, EventBubbles, EventCancelable, EventStatus};
use crate::dom::event::{Event, EventBubbles, EventCancelable, EventComposed, EventStatus};
use crate::dom::globalscope::GlobalScope;
use crate::dom::htmlformelement::FormControlElementHelpers;
use crate::dom::node::{Node, NodeTraits};
@ -767,6 +767,7 @@ impl EventTarget {
name,
EventBubbles::DoesNotBubble,
EventCancelable::NotCancelable,
EventComposed::NotComposed,
can_gc,
)
}
@ -777,6 +778,7 @@ impl EventTarget {
name,
EventBubbles::Bubbles,
EventCancelable::NotCancelable,
EventComposed::NotComposed,
can_gc,
)
}
@ -787,6 +789,7 @@ impl EventTarget {
name,
EventBubbles::DoesNotBubble,
EventCancelable::Cancelable,
EventComposed::NotComposed,
can_gc,
)
}
@ -801,19 +804,22 @@ impl EventTarget {
name,
EventBubbles::Bubbles,
EventCancelable::Cancelable,
EventComposed::NotComposed,
can_gc,
)
}
// https://dom.spec.whatwg.org/#concept-event-fire
/// <https://dom.spec.whatwg.org/#concept-event-fire>
pub(crate) fn fire_event_with_params(
&self,
name: Atom,
bubbles: EventBubbles,
cancelable: EventCancelable,
composed: EventComposed,
can_gc: CanGc,
) -> DomRoot<Event> {
let event = Event::new(&self.global(), name, bubbles, cancelable, can_gc);
event.set_composed(composed.into());
event.fire(self, can_gc);
event
}