Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #11374 - servo:no-microseconds, r=Ms2ger

Browse source 
Don’t include microsecons when reporting build times.

"0:03:40.817715" is harder to read and no more informative than "0:03:40"

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11374)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-05-25 21:31:48 -05:00
commit 345b8b9c00
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
python/servo/build_commands.py
View file

@ -26,6 +26,10 @@ from mach.decorators import (
from servo.command_base import CommandBase, cd, call, BIN_SUFFIX from servo.command_base import CommandBase, cd, call, BIN_SUFFIX
def format_duration(seconds):
return str(datetime.timedelta(seconds=int(seconds)))
def notify_linux(title, text): def notify_linux(title, text):
try: try:
import dbus import dbus
@ -86,7 +90,7 @@ def notify_build_done(elapsed):
"""Generate desktop notification when build is complete and the """Generate desktop notification when build is complete and the
elapsed build time was longer than 30 seconds.""" elapsed build time was longer than 30 seconds."""
if elapsed > 30: if elapsed > 30:
notify("Servo build", "Completed in %s" % str(datetime.timedelta(seconds=elapsed))) notify("Servo build", "Completed in %s" % format_duration(elapsed))
def notify(title, text): def notify(title, text):
@ -240,7 +244,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("Build completed in %s" % str(datetime.timedelta(seconds=elapsed))) print("Build completed in %s" % format_duration(elapsed))
return status return status
@Command('build-cef', @Command('build-cef',
@ -276,7 +280,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("CEF build completed in %s" % str(datetime.timedelta(seconds=elapsed))) print("CEF build completed in %s" % format_duration(elapsed))
return ret return ret
@ -313,7 +317,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("GeckoLib build completed in %s" % str(datetime.timedelta(seconds=elapsed))) print("GeckoLib build completed in %s" % format_duration(elapsed))
return ret return ret
@ -351,7 +355,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("Gonk build completed in %s" % str(datetime.timedelta(seconds=elapsed))) print("Gonk build completed in %s" % format_duration(elapsed))
return ret return ret