auto merge of #1255 : recrack/servo/fix_compute_height, r=metajack

Thanks @metajack
This commit is contained in:
bors-servo 2013-11-14 06:55:31 -08:00
commit 38b17026de

View file

@ -212,9 +212,10 @@ impl BlockFlow {
for &box in self.box.iter() { for &box in self.box.iter() {
let base = box.base(); let base = box.base();
let style = base.style(); let style = base.style();
let maybe_height = MaybeAuto::from_style(style.Box.height, Au::new(0)); height = match MaybeAuto::from_style(style.Box.height, Au::new(0)) {
let maybe_height = maybe_height.specified_or_zero(); Auto => height,
height = geometry::max(height, maybe_height); Specified(value) => value
};
} }
let mut noncontent_height = Au::new(0); let mut noncontent_height = Au::new(0);
@ -238,7 +239,6 @@ impl BlockFlow {
model.margin.bottom; model.margin.bottom;
} }
//TODO(eatkinson): compute heights using the 'height' property.
self.base.position.size.height = height + noncontent_height; self.base.position.size.height = height + noncontent_height;
if inorder { if inorder {