mirror of
https://github.com/servo/servo.git
synced 2025-06-17 12:54:28 +00:00
Auto merge of #23029 - KwanEsq:insertRuleNoIndex, r=SimonSapin
Update StyleSheet.insertRule WebIDL to make index optional. Update wpt metadata to show the new passes. Add one test as crashing since currently passing an \@import rule to insertRule leads to "Expected a stylesheet loader for \@import" --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23025 - [x] There are tests for these changes - [x] ./mach test-wpt css/cssom passes with these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029) <!-- Reviewable:end -->
This commit is contained in:
commit
43cc2a0224
6 changed files with 2 additions and 42 deletions
|
@ -7,6 +7,6 @@
|
||||||
interface CSSStyleSheet : StyleSheet {
|
interface CSSStyleSheet : StyleSheet {
|
||||||
// readonly attribute CSSRule? ownerRule;
|
// readonly attribute CSSRule? ownerRule;
|
||||||
[Throws, SameObject] readonly attribute CSSRuleList cssRules;
|
[Throws, SameObject] readonly attribute CSSRuleList cssRules;
|
||||||
[Throws] unsigned long insertRule(DOMString rule, unsigned long index);
|
[Throws] unsigned long insertRule(DOMString rule, optional unsigned long index = 0);
|
||||||
[Throws] void deleteRule(unsigned long index);
|
[Throws] void deleteRule(unsigned long index);
|
||||||
};
|
};
|
||||||
|
|
|
@ -1,10 +0,0 @@
|
||||||
[insertRule-charset-no-index.html]
|
|
||||||
[inserRule with charset and omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with charset and undefined index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with charset and omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
|
@ -1,7 +0,0 @@
|
||||||
[insertRule-import-no-index.html]
|
|
||||||
[inserRule with import and omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with import and omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
|
@ -1,13 +1,3 @@
|
||||||
[insertRule-namespace-no-index.html]
|
[insertRule-namespace-no-index.html]
|
||||||
[inserRule with namespace and omitted index argument]
|
expected: CRASH
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[inserRule with namespace and omitted index argument should insert import]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with namespace and omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with namespace and omitted index argument should insert import]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
|
|
|
@ -1,10 +0,0 @@
|
||||||
[insertRule-no-index.html]
|
|
||||||
[inserRule with omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with undefined index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[insertRule with omitted index argument]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
|
@ -243,9 +243,6 @@
|
||||||
[MediaList interface: calling deleteMedium(CSSOMString) on style_element.sheet.media with too few arguments must throw TypeError]
|
[MediaList interface: calling deleteMedium(CSSOMString) on style_element.sheet.media with too few arguments must throw TypeError]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
[CSSStyleSheet interface: operation insertRule(CSSOMString, unsigned long)]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[CSSStyleSheet interface: style_element.sheet must inherit property "ownerRule" with the proper type]
|
[CSSStyleSheet interface: style_element.sheet must inherit property "ownerRule" with the proper type]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue