Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Implement 'repeat(auto-fill, <line-names>)' in subgridded axis.

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D46895
This commit is contained in:
Mats Palmgren 2019-09-30 17:32:52 +00:00 • committed by Emilio Cobos Álvarez
parent 4a23556c4b
commit 4a97d6f4a0
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/style/values/generics/grid.rs
View file

@ -646,11 +646,8 @@ impl Parse for LineNameList {
if let Ok((mut names_list, count)) = repeat_parse_result { if let Ok((mut names_list, count)) = repeat_parse_result {
match count { match count {
// FIXME(emilio): we probably shouldn't expand repeat() at // FIXME(emilio): we shouldn't expand repeat() at
// parse time for subgrid. // parse time for subgrid. (bug 1583429)
//
// Also this doesn't have the merging semantics that
// non-subgrid has... But maybe that's ok?
RepeatCount::Number(num) => line_names.extend( RepeatCount::Number(num) => line_names.extend(
names_list names_list
.iter() .iter()
@ -660,6 +657,8 @@ impl Parse for LineNameList {
), ),
RepeatCount::AutoFill if fill_idx.is_none() => { RepeatCount::AutoFill if fill_idx.is_none() => {
// `repeat(autof-fill, ..)` should have just one line name. // `repeat(autof-fill, ..)` should have just one line name.
// FIXME(bug 1341507) the above comment is wrong per:
// https://drafts.csswg.org/css-grid-2/#typedef-name-repeat
if names_list.len() != 1 { if names_list.len() != 1 {
return Err( return Err(
input.new_custom_error(StyleParseErrorKind::UnspecifiedError) input.new_custom_error(StyleParseErrorKind::UnspecifiedError)