Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Drop the usage of @scroll-timeline from animation builder

Browse source 
@scroll-timeline rule was removed from the spec and wpt, so it's safe to
remove this from Gecko.

Differential Revision: https://phabricator.services.mozilla.com/D157248
This commit is contained in:
Boris Chiou 2022-09-22 03:47:11 +00:00 • committed by Martin Robinson
parent 8a63d9e059
commit 4b736595d7
2 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/style/matching.rs
View file

@ -289,7 +289,7 @@ trait PrivateMatchMethods: TElement {
let old_ui_style = old_style.get_ui(); let old_ui_style = old_style.get_ui();
let keyframes_or_timeline_could_have_changed = context let keyframes_could_have_changed = context
.shared .shared
.traversal_flags .traversal_flags
.contains(TraversalFlags::ForCSSRuleChanges); .contains(TraversalFlags::ForCSSRuleChanges);
@ -299,9 +299,9 @@ trait PrivateMatchMethods: TElement {
// element has or will have CSS animation style regardless of whether // element has or will have CSS animation style regardless of whether
// the animation is running or not. // the animation is running or not.
// //
// TODO: We should check which @keyframes/@scroll-timeline were added/changed/deleted and // TODO: We should check which @keyframes were added/changed/deleted and
// update only animations corresponding to those @keyframes/@scroll-timeline. // update only animations corresponding to those @keyframes.
if keyframes_or_timeline_could_have_changed { if keyframes_could_have_changed {
return true; return true;
} }

7
components/style/values/specified/box.rs
View file

@ -816,13 +816,10 @@ pub enum AnimationTimeline {
/// Use default timeline. The animation’s timeline is a DocumentTimeline. /// Use default timeline. The animation’s timeline is a DocumentTimeline.
Auto, Auto,
/// The scroll-timeline name. /// The scroll-timeline name.
/// /// https://drafts.csswg.org/scroll-animations-1/#scroll-timelines-named
/// Note: This could be the timeline name from @scroll-timeline rule, or scroll-timeline-name
/// from itself, its ancestors, or its previous siblings.
/// https://drafts.csswg.org/scroll-animations-1/rewrite#scroll-timelines-named
Timeline(TimelineName), Timeline(TimelineName),
/// The scroll() notation. /// The scroll() notation.
/// https://drafts.csswg.org/scroll-animations-1/rewrite#scroll-notation /// https://drafts.csswg.org/scroll-animations-1/#scroll-notation
#[css(function)] #[css(function)]
Scroll( Scroll(
#[css(skip_if = "is_default")] ScrollAxis, #[css(skip_if = "is_default")] ScrollAxis,