Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-11 01:50:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Thread panics should be a hard-fail in smoketests

Browse source 
This prevents, for instance, a script thread panic from hanging Servo
and means those kind of panics won't cause CI to hang.

Fixes #29749.
This commit is contained in:
Martin Robinson 2023-05-18 09:08:43 +02:00
parent e09f85e17b
commit 6e2d1bdc79
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
python/servo/testing_commands.py
View file

@ -835,6 +835,9 @@ testing/web-platform/mozilla/tests for Servo-only tests""" % reference_path)
@CommandArgument('params', nargs='...',
help="Command-line arguments to be passed through to Servo")
def smoketest(self, params):
params = params + ['tests/html/close-on-load.html']
# We pass `-f` here so that any thread panic will cause Servo to exit,
# preventing a panic from hanging execution. This means that these kind
# of panics won't cause timeouts on CI.
params = params + ['-f', 'tests/html/close-on-load.html']
return self.context.commands.dispatch(
'run', self.context, params=params)