Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix build failure with tracing feature (#35009)

Browse source 
* Fix build failure with tracing feature

Skip tracing preferences for now to avoid:
```
error[E0277]: `Preferences` doesn't implement `std::fmt::Debug`
```

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>

* Fix warning about unused tracing span.

The tracing span is "used" when it is dropped,
so in that sense it is a false positive.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>

---------

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This commit is contained in:
Jonathan Schwender 2025-01-15 21:09:27 +01:00 • committed by GitHub
parent d470f219b1
commit 8fb715847d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/script/dom/bindings/settings_stack.rs
View file

@ -43,6 +43,7 @@ pub(crate) fn is_execution_stack_empty() -> bool {
pub(crate) struct AutoEntryScript { pub(crate) struct AutoEntryScript {
global: DomRoot<GlobalScope>, global: DomRoot<GlobalScope>,
#[cfg(feature = "tracing")] #[cfg(feature = "tracing")]
#[allow(dead_code)]
span: tracing::span::EnteredSpan, span: tracing::span::EnteredSpan,
} }

2
components/servo/lib.rs
View file

@ -227,7 +227,7 @@ where
#[cfg_attr( #[cfg_attr(
feature = "tracing", feature = "tracing",
tracing::instrument( tracing::instrument(
skip(rendering_context, embedder, window), skip(preferences, rendering_context, embedder, window),
fields(servo_profiling = true), fields(servo_profiling = true),
level = "trace", level = "trace",
) )