Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-15 11:23:39 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't increment node revision twice when attaching shadow root to element (#37865)

Browse source 
`Node::dirty` already increments the version. `Node::rev_version`
traverses all ancestors, so it can end up being fairly expensive.

Testing: I'm not sure about WPT coverage but I think this change is
trivial enough to merge without tests.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-07-04 09:10:06 +02:00 • committed by GitHub
parent cf408f7302
commit a6b27c5078
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/script/dom/element.rs
View file

@ -683,7 +683,6 @@ impl Element {
let node = self.upcast::<Node>(); let node = self.upcast::<Node>();
node.dirty(NodeDamage::Other); node.dirty(NodeDamage::Other);
node.rev_version();
Ok(shadow_root) Ok(shadow_root)
} }