Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-20 15:18:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #19303 - emilio:flattened-tree-fallback, r=heycam

Browse source 
style: Account for fallback content in GetFlattenedTreeParent.

Otherwise we may inappropriately style it or what not. This asserts with the
patches of bug 1414999 plus the cleanup of bug 1418456, since we no longer do
StyleNewChildren (which walks over the flattened tree children).

Too bad that GetXBLBinding is a virtual call in Gecko, probably can do just
MAY_BE_IN_BINDING_MGR...

Bug: 1418560
Reviewed-by: heycam
MozReview-Commit-ID: CNU0YdKeaR0

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19303)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-11-20 08:57:50 -06:00 • committed by GitHub
commit bc937f54d1
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/style/gecko/wrapper.rs
View file

@ -227,9 +227,11 @@ impl<'ln> GeckoNode<'ln> {
return false;
}
if parent_el.map_or(false, |el| el.has_shadow_root()) {
if let Some(parent) = parent_el {
if parent.has_shadow_root() || parent.get_xbl_binding().is_some() {
return false;
}
}
true
}