Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-09 17:13:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use call rather than check_call in jquery_test_runner.

Browse source 
The contract for mach commands is to return zero / non-zero to indicate
success / failure, rather than throwing an exception. Since run_jquery.py
uses a 1 exit code when there are unexpected results, this would cause an
exception from check_call, which would then be printed with a stack trace.
This commit is contained in:
Ms2ger 2016-03-16 14:47:26 +01:00
parent ad47c093ad
commit c15fa8bf25
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
python/servo/testing_commands.py
View file

@ -497,8 +497,7 @@ class MachCommands(CommandBase):
# Check that a release servo build exists
bin_path = path.abspath(self.get_binary_path(release, dev))
return check_call(
[run_file, cmd, bin_path, base_dir])
return call([run_file, cmd, bin_path, base_dir])
def dromaeo_test_runner(self, tests, release, dev):
self.ensure_bootstrapped()