mirror of
https://github.com/servo/servo.git
synced 2025-08-06 22:15:33 +01:00
Auto merge of #29810 - MendyBerger:master, r=Loirooriol
css `inset` should work on Layout 2020 <!-- Please describe your changes on the following line: --> `top`, `bottom`, `left`, `right`, are already implemented in layout-2020, so adding the shorthand can be enabled. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29705 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ I'm don't know if I need tests for this, how do I determine that? <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo
GitHub
commit
cc71bfd9c3
8 changed files with 6 additions and 216 deletions
|
|
@ -839,7 +839,7 @@ ${helpers.four_sides_shorthand(
|
|||
"inset",
|
||||
"%s",
|
||||
"specified::LengthPercentageOrAuto::parse",
|
||||
engines="gecko servo-2013",
|
||||
engines="gecko servo-2013 servo-2020",
|
||||
spec="https://drafts.csswg.org/css-logical/#propdef-inset",
|
||||
allow_quirks="No",
|
||||
)}
|
||||
|
|
@ -849,7 +849,7 @@ ${helpers.two_properties_shorthand(
|
|||
"inset-block-start",
|
||||
"inset-block-end",
|
||||
"specified::LengthPercentageOrAuto::parse",
|
||||
engines="gecko servo-2013",
|
||||
engines="gecko servo-2013 servo-2020",
|
||||
spec="https://drafts.csswg.org/css-logical/#propdef-inset-block"
|
||||
)}
|
||||
|
||||
|
|
@ -858,6 +858,6 @@ ${helpers.two_properties_shorthand(
|
|||
"inset-inline-start",
|
||||
"inset-inline-end",
|
||||
"specified::LengthPercentageOrAuto::parse",
|
||||
engines="gecko servo-2013",
|
||||
engines="gecko servo-2013 servo-2020",
|
||||
spec="https://drafts.csswg.org/css-logical/#propdef-inset-inline"
|
||||
)}
|
||||
|
|
|
|||
|
|
@ -1,4 +1,7 @@
|
|||
[animation-002.html]
|
||||
expected: CRASH
|
||||
bug: https://github.com/servo/servo/issues/29891
|
||||
|
||||
[Logical properties in animations respect the writing-mode]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
|||
|
|
@ -8,9 +8,6 @@
|
|||
[Test that inset shorthand sets longhands and serializes correctly.]
|
||||
expected: FAIL
|
||||
|
||||
[Test that inset-* shorthands set the computed value of both logical and physical longhands, with 'writing-mode: horizontal-tb; direction: ltr; '.]
|
||||
expected: FAIL
|
||||
|
||||
[Test that logical inset-* properties share computed values with their physical associates, with 'writing-mode: horizontal-tb; direction: rtl; '.]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
|||
|
|
@ -1,36 +0,0 @@
|
|||
[inset-block-inline-shorthand.html]
|
||||
[e.style['inset-block'\] = "10px" should set inset-block-end]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "10px" should set inset-block-start]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "10px" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "20% auto" should set inset-block-end]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "20% auto" should set inset-block-start]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "20% auto" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "30%" should set inset-inline-end]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "30%" should set inset-inline-start]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "30%" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "auto 40px" should set inset-inline-end]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "auto 40px" should set inset-inline-start]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "auto 40px" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
|
@ -1,24 +0,0 @@
|
|||
[inset-block-inline-valid.html]
|
||||
[e.style['inset-block'\] = "auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "-10px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "calc(10px - 0.5em) -20%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "auto auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "-20%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "calc(10px - 0.5em)" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "-10px auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "auto calc(10px + 0.5em)" should set the property value]
|
||||
expected: FAIL
|
||||
|
|
@ -1,60 +0,0 @@
|
|||
[inset-shorthand.html]
|
||||
[e.style['inset'\] = "1px 2px 3px 4px" should set bottom]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px 4px" should set left]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px 4px" should set right]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px 4px" should set top]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px 4px" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px" should set bottom]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px" should set left]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px" should set right]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px" should set top]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px 3px" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px" should set bottom]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px" should set left]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px" should set right]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px" should set top]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px 2px" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px" should set bottom]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px" should set left]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px" should set right]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px" should set top]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "1px" should not set unrelated longhands]
|
||||
expected: FAIL
|
||||
|
|
@ -1,24 +0,0 @@
|
|||
[inset-valid.html]
|
||||
[e.style['inset'\] = "auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "-10px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "calc(-0.5em + 10px) -20%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "auto auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "10px calc(-0.5em + 10px) -30px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "auto auto auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "10px calc(-0.5em + 10px) auto -30px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset'\] = "auto auto auto auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
|
@ -1,66 +0,0 @@
|
|||
[inset-valid.html]
|
||||
[e.style['inset-block'\] = "0" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "10%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "1rem" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "-10px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "-20%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "calc(2em + 3ex)" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "auto auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "100px 100px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "10% -5px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-block'\] = "1rem calc(0px)" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "0" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "10%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "1rem" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "-10px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "-20%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "calc(2em + 3ex)" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "auto auto" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "100px 100px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "10% -5px" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['inset-inline'\] = "1rem calc(0px)" should set the property value]
|
||||
expected: FAIL
|
||||
Loading…
Add table
Add a link
Reference in a new issue