Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove some fixed fixmes (#33824)

Browse source 
Signed-off-by: Shane Handley <shanehandley@fastmail.com>
This commit is contained in:
shanehandley 2024-10-13 22:56:37 +11:00 • committed by GitHub
parent f0285fc7e5
commit ded518dfd0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/htmlmediaelement.rs
View file

@ -1075,14 +1075,12 @@ impl HTMLMediaElement {
self.error.get().is_some() self.error.get().is_some()
} }
// https://html.spec.whatwg.org/multipage/#potentially-playing /// <https://html.spec.whatwg.org/multipage/#potentially-playing>
fn is_potentially_playing(&self) -> bool { fn is_potentially_playing(&self) -> bool {
!self.paused.get() && !self.paused.get() &&
// FIXME: We need https://github.com/servo/servo/pull/22348 !self.Ended() &&
// to know whether playback has ended or not self.error.get().is_none() &&
// !self.Ended() && !self.is_blocked_media_element()
self.error.get().is_none() &&
!self.is_blocked_media_element()
} }
// https://html.spec.whatwg.org/multipage/#blocked-media-element // https://html.spec.whatwg.org/multipage/#blocked-media-element

1
components/script/dom/webidls/ServiceWorker.webidl
View file

@ -14,7 +14,6 @@ interface ServiceWorker : EventTarget {
attribute EventHandler onstatechange; attribute EventHandler onstatechange;
}; };
// FIXME: use `includes` instead of `implements` after #22539 is fixed.
ServiceWorker includes AbstractWorker; ServiceWorker includes AbstractWorker;
enum ServiceWorkerState { enum ServiceWorkerState {