Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Remove Valgrind workaround to make ::slotted use the rule hash.

Browse source 
Bug: 1426516
Reviewed-by: emilio
MozReview-Commit-ID: 2q14kHjajIr
This commit is contained in:
Emilio Cobos Álvarez 2018-04-23 18:46:10 +02:00
parent b5c18c24fe
commit e5878b96a9
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/style/selector_map.rs
View file

@ -454,13 +454,7 @@ fn specific_bucket_for<'a>(component: &'a Component<SelectorImpl>) -> Bucket<'a>
// //
// So inserting `span` in the rule hash makes sense since we want to // So inserting `span` in the rule hash makes sense since we want to
// match the slotted <span>. // match the slotted <span>.
// Component::Slotted(ref selector) => find_bucket(selector.iter()),
// FIXME(emilio, bug 1426516): The line below causes valgrind failures
// and it's probably a false positive, we should uncomment whenever
// jseward is back to confirm / whitelist it.
//
// Meanwhile taking the code path below is slower, but still correct.
// Component::Slotted(ref selector) => find_bucket(selector.iter()),
Component::Host(Some(ref selector)) => find_bucket(selector.iter()), Component::Host(Some(ref selector)) => find_bucket(selector.iter()),
_ => Bucket::Universal, _ => Bucket::Universal,
} }