Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix "a serious bug" in the bind_to_tree functions

Browse source
This commit is contained in:
Michael Howell 2016-12-06 00:42:29 +00:00
parent 479a2c1217
commit f8121ae60d
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/htmlheadelement.rs
View file

@ -71,7 +71,10 @@ impl VirtualMethods for HTMLHeadElement {
fn super_type(&self) -> Option<&VirtualMethods> { fn super_type(&self) -> Option<&VirtualMethods> {
Some(self.upcast::<HTMLElement>() as &VirtualMethods) Some(self.upcast::<HTMLElement>() as &VirtualMethods)
} }
fn bind_to_tree(&self, _tree_in_doc: bool) { fn bind_to_tree(&self, tree_in_doc: bool) {
if let Some(ref s) = self.super_type() {
s.bind_to_tree(tree_in_doc);
}
load_script(self); load_script(self);
} }
} }

7
components/script/dom/htmltitleelement.rs
View file

@ -71,9 +71,12 @@ impl VirtualMethods for HTMLTitleElement {
} }
} }
fn bind_to_tree(&self, is_in_doc: bool) { fn bind_to_tree(&self, tree_in_doc: bool) {
if let Some(ref s) = self.super_type() {
s.bind_to_tree(tree_in_doc);
}
let node = self.upcast::<Node>(); let node = self.upcast::<Node>();
if is_in_doc { if tree_in_doc {
node.owner_doc().title_changed(); node.owner_doc().title_changed();
} }
} }