Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 06:43:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25240 - pshaughn:unspecial_mouseover, r=SimonSapin

Browse source 
Took out the special mouseover cancel case

<!-- Please describe your changes on the following line: -->
eventtarget.rs was checking the event type to see if it was a mouseover; now it doesn't. Other special-case events like error and beforeunload go down other code paths entirely, so this one has no special cases left.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25190

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2019-12-11 10:12:52 -05:00 • committed by GitHub
commit fc97a53a94
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/script/dom/eventtarget.rs
View file

@ -227,14 +227,13 @@ impl CompiledEventListener {
rooted!(in(*cx) let value = value);
let value = value.handle();
//Step 4
let should_cancel = match event.type_() {
atom!("mouseover") => {
value.is_boolean() && value.to_boolean() == true
},
_ => value.is_boolean() && value.to_boolean() == false,
};
//Step 5
let should_cancel = value.is_boolean() && value.to_boolean() == false;
if should_cancel {
// FIXME: spec says to set the cancelled flag directly
// here, not just to prevent default;
// can that ever make a difference?
event.PreventDefault();
}
}

13
tests/wpt/metadata/html/webappapis/scripting/events/event-handler-processing-algorithm.html.ini
View file

@ -3,16 +3,3 @@
[beforeunload listener returning null cancels event]
bug: https://github.com/servo/servo/issues/10787
expected: FAIL
[mouseover listener returning false cancels event (using Event)]
expected: FAIL
[mouseover listener returning false cancels event (using MouseEvent)]
expected: FAIL
[mouseover listener returning true doesn't cancel event (using Event)]
expected: FAIL
[mouseover listener returning true doesn't cancel event (using MouseEvent)]
expected: FAIL