Commit graph

8447 commits

Author SHA1 Message Date
Manish Goregaokar
8a8a9f7135 Add input validation for AudioParam methods 2019-04-25 16:00:11 -07:00
WPT Sync Bot
d4dc41672a Update web-platform-tests to revision 7a7e16ad8d1a1b843340f47101c0a5c24c9bba57 2019-04-24 00:13:37 -04:00
bors-servo
03b005c7b2
Auto merge of #23178 - tdelacour:ISSUE-21263, r=jdm
Add PerformanceResourceTiming: ResponseEnd

<!-- Please describe your changes on the following line: -->
1. Added `ResponseEnd` to `ResourceAttribute` enum in `net_traits` and added it to the `set_attribute` function on `ResourceFetchTiming`
2. Added `response_end` field to `performanceresourcetiming.rs`
3. In `http_loader.rs`, set ResponseEnd after response body read is complete, or before return due to network error.

I could use a little guidance on testing. After building and running `wpt` tests, I noticed that some tests now "Pass" when they were expected to "Fail". As per the wiki instructions, I've removed those expectations from the `metadata`.

I noticed that there are a handful of other "failing" test expectations associated with `responseEnd`, but those still do not pass. I looked through some similar PRs (`connectEnd`, `redirectStart`, etc) and saw that they also still have a few failing test expectations here and there. Does that mean this is OK for now? How can I better understand which tests we expect to resolve for a given issue? Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21263 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23178)
<!-- Reviewable:end -->
2019-04-23 16:49:12 -04:00
Thomas Delacour
fdbec9835c ISSUE-21263: implemented attribute setting in http loader 2019-04-23 12:33:28 -04:00
bors-servo
54f54d194d
Auto merge of #23186 - krk:enable-css-align-tests, r=jdm
Add css-align tests with failure expectations.

<!-- Please describe your changes on the following line: -->
Enabled `css-align` wpt tests.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20576

<!-- Either: -->
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23186)
<!-- Reviewable:end -->
2019-04-22 17:07:44 -04:00
WPT Sync Bot
a7432be1b3 Update web-platform-tests to revision 8f35eec39a68b77c04b4dbe1f108e4fd86ad7afc 2019-04-22 11:33:36 -04:00
WPT Sync Bot
ecabb8b521 Update web-platform-tests to revision 4657e102531b29ebfbf73b547693288c51c8b8c0 2019-04-20 01:07:12 -04:00
Russell Cousineau
2440e0f98a set referrer in window.load_url
- this conforms to follow-hyperlinks spec step 13
- this conforms to window-open spec step 14.3
- replace uses of `referrer_url` with `referrer`
- in Request class, change "no-referrer" to ""
- set websocket fetch referrer to "no-referrer"
2019-04-19 16:50:38 -07:00
bors-servo
c449cbb8ea
Auto merge of #22769 - gterzian:use_thread_pool_in_resource_thread, r=nox
Use a threadpool for fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22768 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22769)
<!-- Reviewable:end -->
2019-04-19 15:48:56 -04:00
WPT Sync Bot
c5c325d8bb Update web-platform-tests to revision e3cf1284464a4a3e46fd15e4138f8e32c6cecdd8 2019-04-19 00:12:29 -04:00
Gregory Terzian
c52cfda957 use a threadpool for fetch 2019-04-18 15:40:20 +02:00
WPT Sync Bot
39f4d8b931 Update web-platform-tests to revision 20424e735a5e6ac7a474ae35d86c714272aea0e8 2019-04-18 00:23:21 -04:00
WPT Sync Bot
87dcce0f06 Update web-platform-tests to revision 85e8612e81c8b478c8cac7260436646e48d3f7ae 2019-04-17 00:07:02 -04:00
bors-servo
b9d625f16e
Auto merge of #23206 - servo-wpt-sync:wpt_update_16-04-2019, r=servo-wpt-sync
Sync WPT with upstream (16-04-2019)

Automated downstream sync of changes from upstream as of 16-04-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23206)
<!-- Reviewable:end -->
2019-04-16 04:38:39 -04:00
WPT Sync Bot
c8202ddbe1 Update web-platform-tests to revision fd0429f0b45f975b25d85256dac33762134952c5 2019-04-16 00:29:32 -04:00
bors-servo
456ea6a388
Auto merge of #23153 - 5h1rU:xmlserializer-serializetostring-panics, r=jdm
Make serializeToString serialize document nodes correctly

<!-- Please describe your changes on the following line: -->
This is the fix for ScriptThread panic when `new XMLSerializer().serializeToString(document);` is called.

r?@jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23130

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23153)
<!-- Reviewable:end -->
2019-04-15 23:30:56 -04:00
Felipe Janer
1ffe8f059a Add new XMLSerializer().serializeToString functionality 2019-04-15 21:12:47 -05:00
WPT Sync Bot
f80ff24202 Update web-platform-tests to revision 3efff9b2d66aed3d8e2061205069883fd54df2be 2019-04-13 00:22:52 -04:00
bors-servo
9832feddf3
Auto merge of #23192 - jackxbritton:issue-23134, r=jdm
Implement DocumentFragment XML serialization.

When serializing a DocumentFragment node, we should follow [this guy](https://w3c.github.io/DOM-Parsing/#dfn-xml-serializing-a-documentfragment-node) and serialize the node's immediate children. This commit makes that change.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #23134 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___ well, they probably do, but I don't know how to do that and could use some help.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23192)
<!-- Reviewable:end -->
2019-04-12 14:37:45 -04:00
Jack Britton
1dd1cb4f4f Implement DocumentFragment XML serialization. 2019-04-12 12:49:18 -04:00
WPT Sync Bot
dd79cdc697 Update web-platform-tests to revision 386d27678c48bf468b8d374e2ba718e32185a5b7 2019-04-12 01:21:13 -04:00
WPT Sync Bot
7e807a0d1e Update web-platform-tests to revision e3d0146264093a389148cc555ee9be69bd75719b 2019-04-11 00:31:30 -04:00
krk
4af50f96fa Add css-align tests with failure expectations. 2019-04-10 21:41:02 +02:00
Josh Matthews
1bdca9ce84
Delete Secure-Send-binary-65K-arraybuffer.any.js.ini 2019-04-09 07:17:43 -04:00
WPT Sync Bot
1a4444a557 Update web-platform-tests to revision 687b6cba3385c4c2ca85f44fe072961e651621b5 2019-04-09 00:21:08 -04:00
WPT Sync Bot
733bcbdd2b Update web-platform-tests to revision 2221fe343f0f4cb4e4e382bfd43bc8b1e69a98ba 2019-04-08 00:34:34 -04:00
bors-servo
8073e9a505
Auto merge of #23174 - soniasingla:DefaultPaths, r=jdm
Add default paths for WPT tests

Set the following default configs for WPT tests.
```--ca-cert-path=tests\wpt\web-platform-tests\tools\certs\cacert.pem
--host-key-path=tests\wpt\web-platform-tests\tools\certs\web-platform.test.key
--host-cert-path=tests\wpt\web-platform-tests\tools\certs\web-platform.test.pem
--ssl-type=pregenerated
```
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23133

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23174)
<!-- Reviewable:end -->
2019-04-07 12:18:17 -04:00
Sonia Singla
9d48ca1298 fix identation 2019-04-07 20:37:05 +05:30
Sonia Singla
37259d216d Add default paths for WPT tests 2019-04-07 18:17:07 +05:30
WPT Sync Bot
401e01095b Update web-platform-tests to revision 923923a01f38577f471b1e613c4223a21ac027ff 2019-04-07 00:02:56 -04:00
WPT Sync Bot
ce9f8f32f1 Update web-platform-tests to revision 4688078c2cc6e81651b220f3c1944d956f63046b 2019-04-05 23:55:05 -04:00
WPT Sync Bot
2575230dce Update web-platform-tests to revision 0cde5f6b37c9b3e3f9153eb1b172680e9aea9bf9 2019-04-05 00:50:36 -04:00
bors-servo
f142b1d1c7
Auto merge of #23145 - pylbrecht:performance.resource.timing, r=jdm
Add connectEnd attribute to PerformanceResourceTiming interface

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #21262

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23145)
<!-- Reviewable:end -->
2019-04-04 18:39:35 -04:00
pylbrecht
f478357567 Add connectEnd attribute to PerformanceResourceTiming interface 2019-04-04 07:19:25 +02:00
WPT Sync Bot
bde105ca2e Update web-platform-tests to revision b8669365b81965f5400d6b13a7783415b44e679d 2019-04-03 23:56:16 -04:00
bors-servo
6fa1853bb1
Auto merge of #23156 - servo-wpt-sync:wpt_update_03-04-2019, r=jdm
Sync WPT with upstream (03-04-2019)

Automated downstream sync of changes from upstream as of 03-04-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23156)
<!-- Reviewable:end -->
2019-04-03 07:17:10 -04:00
Josh Matthews
01b82f5e68
remove intermittent failure. 2019-04-03 07:16:29 -04:00
bors-servo
b9b729caa0
Auto merge of #23103 - ferjm:srcObject, r=Manishearth
Implement srcObject logic for Blob media providers

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23103)
<!-- Reviewable:end -->
2019-04-03 05:05:32 -04:00
WPT Sync Bot
52045cb370 Update web-platform-tests to revision 0a28ecf697d96db228f8382db0e41f1c54314dad 2019-04-03 00:53:26 -04:00
Josh Matthews
4138fb689b
Delete insecure-protocol.http.html.ini
Remove intermittent failure.
2019-04-02 10:15:44 -04:00
WPT Sync Bot
b55cc798b6 Update web-platform-tests to revision 3bbb55915a04548e70c63b7c143a83e0e9d3c5e7 2019-04-02 01:37:24 -04:00
WPT Sync Bot
f62d961249 Update web-platform-tests to revision f24d88b7d2cd2d851533e9c1180b1c5c5d118bc3 2019-03-31 23:38:25 -04:00
WPT Sync Bot
7cb8ac2fe2 Update web-platform-tests to revision d4f8820261cce3f9ee37353b6d76d247cb12a972 2019-03-30 23:51:59 -04:00
WPT Sync Bot
6ed2abf735 Update web-platform-tests to revision add24188a1226f3598ad6b455e71641c9ac6a5fd 2019-03-29 23:56:29 -04:00
Maharsh
6c6fb676b7 Created CanvasRect fro OffscreenCanvas and Updated Testcases 2019-03-29 15:12:53 -04:00
WPT Sync Bot
cb63cfd5c7 Update web-platform-tests to revision 3bfdeb8976fc51748935c8d1f1014dfba8e08dfb 2019-03-29 00:51:32 -04:00
Fernando Jiménez Moreno
d15640081c Implement srcObject logic for Blob media providers 2019-03-27 07:11:29 +01:00
George Roman
e63de4d52c Update Event's timestamp 2019-03-26 09:39:07 +02:00
bors-servo
5ae562bfc3
Auto merge of #22944 - ferjm:player.shutdown, r=ceyusa
Shutdown player when HTMLMediaElement is dropped

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22931
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22944)
<!-- Reviewable:end -->
2019-03-25 07:47:06 -04:00
Fernando Jiménez Moreno
36825b82f3 Shutdown player when HTMLMediaElement is dropped 2019-03-25 09:29:30 +01:00