bors-servo
01b4deb9d1
Auto merge of #8693 - yanirs:websocket-close-unspecified-status, r=jdm
...
Implement unspecified websocket close code (fixes issue #8158 )
Fixes #8158 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8693 )
<!-- Reviewable:end -->
2015-12-03 11:56:18 +05:30
bors-servo
20df7fb7c8
Auto merge of #7988 - nox:unforgeable, r=jdm
...
Implement [Unforgeable]
This is mostly stolen from Gecko. As there, we define the unforgeable members
on an object stored in the slots of the prototype object. They are then copied
onto instance objects when they are instantiated. It should be noted that
proxy objects see their unforgeable memebers defined on their expando object.
Unforgeable attributes aren't properly inherited in codegen (in a similar
fashion as getters and setters as filed in #5875 ) and require to be redefined
in derived interfaces. Fortunately, there are currently no such interfaces.
No unforgeable members can be included into the TestBinding interfaces for good
measure because they are not compatible with setters.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7988 )
<!-- Reviewable:end -->
2015-12-03 11:03:05 +05:30
bors-servo
fc3e950052
Auto merge of #7323 - samfoo:input-maxlength, r=jdm
...
Adds support for input element's maxlength attr
This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength ) for input elements.
Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)
servo/servo#7320
servo/servo#7004
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7323 )
<!-- Reviewable:end -->
2015-12-03 10:28:24 +05:30
Sam Gibson
4befd2cfb0
Fixes typo in test literal
2015-12-03 14:10:25 +11:00
Sam Gibson
d375ac271d
Fix manifest update
2015-12-03 14:01:01 +11:00
Sam Gibson
7ba43913c2
Uses assert_throws instead of explicit try/catch
2015-12-03 14:01:00 +11:00
Sam Gibson
9668500e97
Makes setting negative values to maxLength throw an IndexSize exception
2015-12-03 14:00:59 +11:00
Sam Gibson
51ca659f8a
Add maxlength wpt to manifest
2015-12-03 14:00:58 +11:00
Sam Gibson
6d1624f9d0
Add additional WPT tests for maxlength parser set
2015-12-03 14:00:57 +11:00
Sam Gibson
85b99f8ba4
Fix typo in error message
2015-12-03 14:00:56 +11:00
Sam Gibson
32627a475a
Add maxlength manual test for input
2015-12-03 14:00:56 +11:00
Sam Gibson
ecc7035de6
Correct the default max length
2015-12-03 14:00:55 +11:00
Sam Gibson
5450d49f57
Removes failure expectations for input.maxLength WPT tests
2015-12-03 14:00:54 +11:00
Sam Gibson
2ba1750c40
Resolves long-running merge conflicts
2015-12-03 14:00:53 +11:00
Sam Gibson
419a26e619
Adds a test for set_content to ignore max_length
2015-12-03 14:00:53 +11:00
Sam Gibson
eecdfdf6c1
Makes int_getter macro, and uses -1 as default maxlength instead of maxint
2015-12-03 14:00:52 +11:00
Sam Gibson
d26c555e2a
Adds support for input element's maxlength attr
...
servo/servo#7320
servo/servo#7004
2015-12-03 14:00:51 +11:00
Anthony Ramine
60976406cc
Implement [Unforgeable]
...
This is mostly stolen from Gecko. As there, we define the unforgeable members
on an object stored in the slots of the prototype object. They are then copied
onto instance objects when they are instantiated. It should be noted that
proxy objects see their unforgeable memebers defined on their expando object.
Unforgeable attributes aren't properly inherited in codegen (in a similar
fashion as getters and setters as filed in #5875 ) and require to be redefined
in derived interfaces. Fortunately, there are currently no such interfaces.
No unforgeable members can be included into the TestBinding interfaces for good
measure because they are not compatible with setters.
Given the unforgeable holder object has the same prototype as actual instances
of the interface, the finalize hook needs to check its slot pointer for nullity
before dropping it.
The new failing test isn't related to Unforgeable attributes, but to the fact
that all Document instances currently have a Location, even if their window
isn't in a browsing context.
2015-12-02 22:15:11 +01:00
bors-servo
2be60be062
Auto merge of #8776 - samfoo:hsts-preload-download-fix, r=jdm
...
Fix the parsing of the chromium HSTS preload list
Urg! The Chromium HSTS preload JSON file contains single line comments. Previously these were filtered out with a very simple regex that just looked for '//' and removed the line. Now the file has added a couple fields that have URLs in them that were erroneously removed and caused the JSON parsing to fail. This commit slightly complicates the regex to fix this specific problem.
If this happens again, it's likely worth it to figure out how to use a real parser to remove the comments.
servo/servo#8760
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8776 )
<!-- Reviewable:end -->
2015-12-02 10:25:05 +05:30
Sam Gibson
732ae5714f
Fix the parsing of the chromium HSTS preload list
...
Urg! The Chromium HSTS preload JSON file contains single line comments. Previously these were filtered out with a very simple regex that just looked for '//' and removed the line. Now the file has added a couple fields that have URLs in them that were erroneously removed and caused the JSON parsing to fail. This commit slightly complicates the regex to fix this specific problem.
If this happens again, it's likely worth it to figure out how to use a real parser to remove the comments.
servo/servo#8760
2015-12-02 15:36:38 +11:00
bors-servo
a8cbc28643
Auto merge of #8742 - jmr0:master, r=Ms2ger
...
adding wpt lint script to tidy checks
Fixes #8285 .
Tidy check will fail, however, until we merge the latest https://github.com/w3c/web-platform-tests/blob/master/lint.whitelist
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8742 )
<!-- Reviewable:end -->
2015-12-01 22:21:37 +05:30
bors-servo
65108348aa
Auto merge of #8714 - frewsxcv:body-fgcolor, r=Ms2ger
...
Implement attribute 'fgColor' on 'document'
The 'text' attribute was implemented on `<body>` in #7841
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8714 )
<!-- Reviewable:end -->
2015-12-01 21:40:58 +05:30
bors-servo
b4906aa008
Auto merge of #8755 - glennw:vsync, r=pcwalton
...
Add debug option to disable vsync for profiling.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8755 )
<!-- Reviewable:end -->
2015-12-01 05:26:00 +05:30
Glenn Watson
6c8905126f
Add debug option to disable vsync for profiling.
2015-12-01 09:52:13 +10:00
Corey Farwell
320263199f
Implement attribute 'fgColor' on 'document'
...
The 'text' attribute was implemented on '<body>' in #7841
2015-11-30 18:19:07 -05:00
bors-servo
51c19fd733
Auto merge of #8558 - jdm:crossoriginiframeload, r=glennw
...
Dispatch load events for cross origin iframes. Resolves #6672 .
Splitting it out from #6677 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8558 )
<!-- Reviewable:end -->
2015-12-01 04:09:11 +05:30
Josh Matthews
c23cbd4163
Dispatch load events for cross origin iframes. Resolves #6672 .
2015-11-30 17:37:16 -05:00
bors-servo
2a125b5613
Auto merge of #8731 - eefriedman:root-lint-pattern, r=Manishearth
...
Fix false positive in unrooted_must_root lint.
Encountered in #8725 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8731 )
<!-- Reviewable:end -->
2015-12-01 00:24:03 +05:30
Eli Friedman
962c06e9da
Fix false positive in unrooted_must_root lint.
...
Encountered in #8725 .
2015-11-30 10:53:32 -08:00
bors-servo
595bda478e
Auto merge of #8752 - Manishearth:om-nom, r=metajack
...
Make `path_matches` match the spec (fixes cookies)
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8752 )
<!-- Reviewable:end -->
2015-11-30 23:18:39 +05:30
Manish Goregaokar
d332557d69
Add path_match tests
2015-11-30 22:56:13 +05:30
Manish Goregaokar
f8d906be10
Make path_matches match the spec (fixes cookies)
2015-11-30 22:01:33 +05:30
jmr0
e301ff46b2
adding wpt lint script to tidy checks
2015-11-30 10:08:10 -05:00
bors-servo
29c42a9f78
Auto merge of #8751 - nox:rm-prototype-slot, r=Ms2ger
...
Remove unused slot in prototype object (fixes #8588 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8751 )
<!-- Reviewable:end -->
2015-11-30 19:27:57 +05:30
Anthony Ramine
7547bcac24
Remove unused slot in prototype object ( fixes #8588 )
2015-11-30 14:48:24 +01:00
bors-servo
a27a15f94b
Auto merge of #8736 - Ms2ger:test-ref, r=frewsxcv
...
Use wptrunner for some old-style reftests.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8736 )
<!-- Reviewable:end -->
2015-11-30 18:56:26 +05:30
bors-servo
78a298bdba
Auto merge of #8748 - Ms2ger:update-tests, r=Ms2ger
...
Update tests.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8748 )
<!-- Reviewable:end -->
2015-11-30 18:14:56 +05:30
Ms2ger
3bbee99cdb
Update web-platform-tests to revision a3b0fadc7f5001bbe52c65e0a354c454981423a3
2015-11-30 13:44:18 +01:00
Ms2ger
6bb495338b
Update CSS tests to revision 4e1aa4f3dcbff1abd654c63d0f677379c1e2775f
2015-11-30 12:21:03 +01:00
bors-servo
0f72049363
Auto merge of #8705 - jsanders:fix-sleep-ms-deprecations, r=metajack,Wafflespeanut
...
Use thread::sleep instead of deprecated sleep_ms
Similarly, change one instance of `thread::park_timeout_ms`.
Fixes #8694
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8705 )
<!-- Reviewable:end -->
2015-11-30 09:20:15 +05:30
Yanir Seroussi
ad9accf8e7
Implement unspecified websocket close code (fixes issue #8158 )
2015-11-30 11:20:41 +11:00
bors-servo
a877a56e0e
Auto merge of #8661 - craftytrickster:8623/some-webdriver-commands, r=jgraham
...
Webdriver - GetWindowSize/IsEnabled/IsSelected
Added handlers for https://github.com/servo/servo/issues/8623 :
GetWindowSize
IsEnabled(WebElement)
IsSelected(WebElement)
I am not sure how to actually verify my webdriver code works, if someone can give advice I would make the necessary changes.
Thanks!
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8661 )
<!-- Reviewable:end -->
2015-11-30 03:42:54 +05:30
David Raifaizen
8d451076e1
Removed duplicate webdriver_traits file and added webdriver handler for GetWindowSize, IsSelected and IsEnabled
2015-11-29 15:48:23 -05:00
James Sanders
3659218c59
Use thread::sleep instead of deprecated sleep_ms
...
Similarly, change one instance of `thread::park_timeout_ms`.
Fixes #8694
2015-11-29 13:41:04 -07:00
Ms2ger
ae6585da88
Move overconstrained_block.html to wpt reftests.
2015-11-29 10:57:16 +01:00
Ms2ger
facee849c2
Move link_style_dynamic_addition.html to wpt reftests.
2015-11-29 10:57:15 +01:00
Ms2ger
27e3ca61ec
Move linebreak_simple_a.html to wpt reftests.
2015-11-29 10:57:14 +01:00
Ms2ger
7641d5b1e3
Remove inline_border_a.html.
...
It compares to a screenshot that doesn't match.
2015-11-29 10:57:13 +01:00
Ms2ger
51af73d872
Fix the metadata file for size_attributes_vertical_writing_mode.html.
2015-11-29 10:57:12 +01:00
bors-servo
b737e4e0fa
Auto merge of #8735 - echochamber:OnErrorEventHandlerNonNull-return-any, r=KiChjang
...
Make OnErrorEventHandlerNonNull return 'any' instead of 'boolean'.
PR to fix #8710
> I think the specification must have changed since this was first added to Servo: https://html.spec.whatwg.org/multipage/webappapis.html#onerroreventhandler
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8735 )
<!-- Reviewable:end -->
2015-11-29 15:00:19 +05:30
